GUMS bl
| Class | Class Todos Count | Method with Todos |
|---|---|---|
| gov.bnl.gums.AccountPoolMapper | 1 | 0 |
| gov.bnl.gums.AccountPoolMapperDB | 0 | 1 |
| gov.bnl.gums.CompositeAccountMapper | 1 | 0 |
| gov.bnl.gums.GUMS | 0 | 1 |
| gov.bnl.gums.ManualAccountMapperDB | 0 | 2 |
| gov.bnl.gums.MySQLPersistenceFactory | 1 | 0 |
| gov.bnl.gums.ResourceManager | 0 | 1 |
| gov.bnl.gums.UserGroup | 0 | 1 |
| gov.bnl.gums.VOMSGroup | 1 | 0 |
| Method Todos |
|---|
| assignAccount(): decide which exception are thrown when |
| Class Todos |
|---|
| it might be better to define an exception AccountMappingException that goes through, while the other are catched, logged and the iteration continues. |
| Method Todos |
|---|
| setConfiguration(): should this method actually save the configuration? |
| Method Todos |
|---|
| createMapping(): should decide which excpetion to throw if the account was found, and should modify the unit tests to test the error condition |
| Method Todos |
|---|
| removeMapping(): should probabily test the result value in unit tests |
| Class Todos |
|---|
| query depends on version of MySQL: should check it. |
| Method Todos |
|---|
| generateGridMapfile(): usersInMap should be a sorted list to make things faster, but no ready made implementation was found. |
| Method Todos |
|---|
| getName(): this is probably not useful, and can be confusing: should be removed. |