Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
115 | 0 | 0 | 3024 |
Files
gov/bnl/gums/AbstractHostGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
23
|
| Line has trailing spaces. |
24
|
| Method 'getGroupMappers' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Line has trailing spaces. |
31
|
| Method 'setGroupMapper' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Parameter groupMapper should be final. |
36
|
| 'groupMapper' hides a field. |
36
|
| Line has trailing spaces. |
39
|
gov/bnl/gums/AccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
17
|
| Line is longer than 80 characters. |
20
|
| Line has trailing spaces. |
24
|
gov/bnl/gums/AccountPoolMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter userDN should be final. |
24
|
| 'if' construct must use '{}'s. |
26
|
| Line has trailing spaces. |
28
|
| Line has trailing spaces. |
29
|
| Method 'getPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Line has trailing spaces. |
33
|
| Line is longer than 80 characters. |
34
|
| Method 'setPersistence' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter persistanceFactory should be final. |
34
|
| 'persistanceFactory' hides a field. |
34
|
| Parameter name should be final. |
34
|
| 'name' hides a field. |
34
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
gov/bnl/gums/AccountPoolMapperDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
22
|
| Line is longer than 80 characters. |
24
|
| Line has trailing spaces. |
27
|
| Line has trailing spaces. |
33
|
| Line has trailing spaces. |
41
|
| Line has trailing spaces. |
46
|
| First sentence should end with a period. |
47
|
| Line has trailing spaces. |
52
|
| Line is longer than 80 characters. |
53
|
gov/bnl/gums/BNLPersistenceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
26
|
| Missing a Javadoc comment. |
27
|
| Line is longer than 80 characters. |
28
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Method 'retrieveUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter name should be final. |
38
|
| 'name' hides a field. |
38
|
| Method 'retrieveManualUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter name should be final. |
42
|
| 'name' hides a field. |
42
|
| Method 'retrieveManualAccountMapperDB' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter name should be final. |
46
|
| 'name' hides a field. |
46
|
| Method 'retrieveAccountPoolMapperDB' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter name should be final. |
50
|
| 'name' hides a field. |
50
|
| Line has trailing spaces. |
66
|
| Missing a Javadoc comment. |
67
|
| Line has trailing spaces. |
68
|
| Missing a Javadoc comment. |
69
|
| Missing a Javadoc comment. |
70
|
| Missing a Javadoc comment. |
71
|
| Line has trailing spaces. |
72
|
| Line is longer than 80 characters. |
73
|
| Missing a Javadoc comment. |
73
|
| Parameter poolname should be final. |
73
|
| Parameter group should be final. |
73
|
| 'group' hides a field. |
73
|
| Parameter secondaryGroups should be final. |
73
|
| 'secondaryGroups' hides a field. |
73
|
| Line has trailing spaces. |
78
|
| Missing a Javadoc comment. |
79
|
| Parameter user should be final. |
79
|
| Missing a Javadoc comment. |
83
|
| Parameter userDN should be final. |
83
|
| Line has trailing spaces. |
90
|
| Missing a Javadoc comment. |
91
|
| Parameter username should be final. |
91
|
| 'group' hides a field. |
96
|
| Line is longer than 80 characters. |
98
|
| Missing a Javadoc comment. |
102
|
| Parameter userDN should be final. |
102
|
| 'if' construct must use '{}'s. |
104
|
| Missing a Javadoc comment. |
117
|
| Parameter account should be final. |
117
|
| Missing a Javadoc comment. |
121
|
| Parameter date should be final. |
121
|
| Missing a Javadoc comment. |
125
|
| Line has trailing spaces. |
128
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
131
|
| Missing a Javadoc comment. |
131
|
| Line has trailing spaces. |
134
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Missing a Javadoc comment. |
135
|
| Parameter name should be final. |
135
|
| 'name' hides a field. |
135
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Missing a Javadoc comment. |
139
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
143
|
| Missing a Javadoc comment. |
143
|
| Parameter properties should be final. |
143
|
| 'properties' hides a field. |
143
|
| Line has trailing spaces. |
148
|
| Method 'getMySQLProperties' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Missing a Javadoc comment. |
149
|
| Line has trailing spaces. |
152
|
| Missing a Javadoc comment. |
153
|
| Parameter prefix should be final. |
153
|
| 'name' hides a field. |
157
|
| Line is longer than 80 characters. |
159
|
| Line has trailing spaces. |
164
|
| Method 'getLDAPProperties' is not designed for extension - needs to be abstract, final or empty. |
165
|
| Missing a Javadoc comment. |
165
|
| Method 'isSynchGroups' is not designed for extension - needs to be abstract, final or empty. |
173
|
| Method 'setSynchGroups' is not designed for extension - needs to be abstract, final or empty. |
182
|
| Parameter synchGroups should be final. |
182
|
| 'synchGroups' hides a field. |
182
|
| Line has trailing spaces. |
186
|
gov/bnl/gums/CertificateHostGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
28
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter hostname should be final. |
29
|
| 'if' construct must use '{}'s. |
32
|
| Line has trailing spaces. |
37
|
| Method 'getCn' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Line has trailing spaces. |
44
|
| Method 'setCn' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Parameter cn should be final. |
48
|
| 'cn' hides a field. |
48
|
| Line has trailing spaces. |
52
|
| Line is longer than 80 characters. |
54
|
| Method 'getDn' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
61
|
| Unused @param tag for 'wildcard'. |
61
|
| Method 'setDn' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Parameter dn should be final. |
63
|
| 'dn' hides a field. |
63
|
| Expected @param tag for 'dn'. |
63
|
| Line has trailing spaces. |
67
|
| Missing a Javadoc comment. |
68
|
gov/bnl/gums/CompositeAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
26
|
| Line has trailing spaces. |
31
|
| Missing a Javadoc comment. |
32
|
| Method 'setMappers' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Parameter mappers should be final. |
42
|
| 'mappers' hides a field. |
42
|
| Line has trailing spaces. |
45
|
| Method 'getMappers' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Line has trailing spaces. |
58
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Parameter userDN should be final. |
59
|
| 'if' construct must use '{}'s. |
64
|
| Line has trailing spaces. |
68
|
| Line is longer than 80 characters. |
71
|
| Method 'addMapper' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter mapper should be final. |
73
|
| Line has trailing spaces. |
76
|
gov/bnl/gums/Configuration.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
10
|
| Missing a Javadoc comment. |
21
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Method 'getHostGroup' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Line has trailing spaces. |
36
|
| Method 'getGroupMapping' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Line has trailing spaces. |
45
|
| Method 'getPersistenceFactories' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Line has trailing spaces. |
55
|
| Method 'getAllGroups' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Line has trailing spaces. |
64
|
| Method 'addPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Parameter factory should be final. |
69
|
| Line has trailing spaces. |
73
|
| Method 'addGroupMapping' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Parameter group should be final. |
78
|
| Line has trailing spaces. |
85
|
| Method 'addHostGroup' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Parameter mapping should be final. |
90
|
| Method 'getAdminGroup' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Method 'setAdminGroup' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Parameter adminGroup should be final. |
108
|
| 'adminGroup' hides a field. |
108
|
| Method 'isErrorOnMissedMapping' is not designed for extension - needs to be abstract, final or empty. |
122
|
| Method 'setErrorOnMissedMapping' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Parameter errorOnMissedMapping should be final. |
130
|
| 'errorOnMissedMapping' hides a field. |
130
|
gov/bnl/gums/ConfigurationStore.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
9
|
| Line has trailing spaces. |
38
|
| Expected @param tag for 'conf'. |
40
|
| Line has trailing spaces. |
41
|
gov/bnl/gums/ConfigurationToolkit.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
11
|
| Using the '.*' form of import should be avoided - org.apache.commons.digester.*. |
13
|
| Utility classes should not have a public or default constructor. |
23
|
| Missing a Javadoc comment. |
24
|
| Line has trailing spaces. |
25
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter url should be final. |
26
|
| Line has trailing spaces. |
33
|
| Line is longer than 80 characters. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter filename should be final. |
34
|
| Line has trailing spaces. |
41
|
| Missing a Javadoc comment. |
42
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
57
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
62
|
| Line has trailing spaces. |
63
|
| Line is longer than 80 characters. |
64
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
68
|
| Line has trailing spaces. |
70
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
77
|
| Line has trailing spaces. |
78
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
82
|
| Line is longer than 80 characters. |
87
|
| Line has trailing spaces. |
89
|
| Line has trailing spaces. |
92
|
| Missing a Javadoc comment. |
93
|
| Line has trailing spaces. |
94
|
| Line is longer than 80 characters. |
95
|
| Missing a Javadoc comment. |
95
|
| Parameter str should be final. |
95
|
| Parameter str1 should be final. |
95
|
| Parameter attributes should be final. |
95
|
| Line has trailing spaces. |
106
|
| Line has trailing spaces. |
108
|
| Missing a Javadoc comment. |
109
|
| Line has trailing spaces. |
110
|
| Line is longer than 80 characters. |
111
|
| Missing a Javadoc comment. |
111
|
| Parameter str should be final. |
111
|
| Parameter str1 should be final. |
111
|
| Parameter attributes should be final. |
111
|
| Line is longer than 80 characters. |
115
|
| Line has trailing spaces. |
118
|
| Line has trailing spaces. |
120
|
| Missing a Javadoc comment. |
121
|
| Line has trailing spaces. |
122
|
| Line is longer than 80 characters. |
123
|
| Missing a Javadoc comment. |
123
|
| Parameter str should be final. |
123
|
| Parameter str1 should be final. |
123
|
| Parameter attributes should be final. |
123
|
| Line is longer than 80 characters. |
127
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
137
|
| Line has trailing spaces. |
140
|
| Line has trailing spaces. |
142
|
gov/bnl/gums/FQAN.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
34
|
| Line has trailing spaces. |
35
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Line has trailing spaces. |
39
|
| Line is longer than 80 characters. |
41
|
| Parameter fqan should be final. |
45
|
| 'fqan' hides a field. |
45
|
| Line has trailing spaces. |
50
|
| Line has trailing spaces. |
52
|
| Parameter vo should be final. |
59
|
| 'vo' hides a field. |
59
|
| Parameter group should be final. |
59
|
| 'group' hides a field. |
59
|
| Parameter role should be final. |
59
|
| 'role' hides a field. |
59
|
| Parameter capability should be final. |
59
|
| 'capability' hides a field. |
59
|
| 'if' construct must use '{}'s. |
60
|
| Line is longer than 80 characters. |
61
|
| Line has trailing spaces. |
68
|
| Line has trailing spaces. |
70
|
| Line is longer than 80 characters. |
71
|
| Method 'getFqan' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Missing a Javadoc comment. |
77
|
| Parameter fqan should be final. |
77
|
| 'fqan' hides a field. |
77
|
| Line has trailing spaces. |
82
|
| Method 'getVo' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Line has trailing spaces. |
88
|
| Missing a Javadoc comment. |
89
|
| Parameter vo should be final. |
89
|
| 'vo' hides a field. |
89
|
| Line is longer than 80 characters. |
91
|
| Line has trailing spaces. |
95
|
| Line has trailing spaces. |
97
|
| Method 'getGroup' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Line has trailing spaces. |
103
|
| Missing a Javadoc comment. |
104
|
| Parameter group should be final. |
104
|
| 'group' hides a field. |
104
|
| Line is longer than 80 characters. |
106
|
| Line has trailing spaces. |
110
|
| Line has trailing spaces. |
112
|
| Method 'getRole' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Line has trailing spaces. |
118
|
| Missing a Javadoc comment. |
119
|
| Parameter role should be final. |
119
|
| 'role' hides a field. |
119
|
| Line is longer than 80 characters. |
121
|
| Line has trailing spaces. |
128
|
| Method 'getCapability' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Line has trailing spaces. |
136
|
| Missing a Javadoc comment. |
137
|
| Parameter capability should be final. |
137
|
| 'capability' hides a field. |
137
|
| Line is longer than 80 characters. |
139
|
| Line has trailing spaces. |
146
|
| Missing a Javadoc comment. |
147
|
| Parameter fqan should be final. |
147
|
| 'fqan' hides a field. |
147
|
| 'if' construct must use '{}'s. |
150
|
| Line is longer than 80 characters. |
151
|
| Line has trailing spaces. |
152
|
| Line is longer than 80 characters. |
163
|
| '5' is a magic number. |
174
|
| '11' is a magic number. |
182
|
| Line has trailing spaces. |
185
|
| Missing a Javadoc comment. |
186
|
| 'if' construct must use '{}'s. |
194
|
| Line has trailing spaces. |
206
|
| Line has trailing spaces. |
208
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Line has trailing spaces. |
214
|
| Line has trailing spaces. |
216
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
219
|
| 'if' construct must use '{}'s. |
220
|
| Line has trailing spaces. |
223
|
| Line has trailing spaces. |
226
|
| Line is longer than 80 characters. |
228
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
230
|
| Parameter obj should be final. |
230
|
| 'if' construct must use '{}'s. |
231
|
| Avoid inline conditionals. |
233
|
| Line has trailing spaces. |
235
|
gov/bnl/gums/FileConfigurationStore.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
13
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Line has trailing spaces. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
31
|
| Line has trailing spaces. |
33
|
| First sentence should end with a period. |
34
|
| Parameter filename should be final. |
36
|
| 'filename' hides a field. |
36
|
| Expected @param tag for 'filename'. |
36
|
| Line has trailing spaces. |
39
|
| Method 'isActive' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Line has trailing spaces. |
44
|
| Method 'isReadOnly' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Line has trailing spaces. |
48
|
| Method 'getConfURL' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Line has trailing spaces. |
52
|
| Method 'retrieveConfiguration' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| 'if' construct must use '{}'s. |
54
|
| Line is longer than 80 characters. |
57
|
| Line has trailing spaces. |
61
|
| Missing a Javadoc comment. |
62
|
| Line is longer than 80 characters. |
77
|
| Line has trailing spaces. |
81
|
| Missing a Javadoc comment. |
82
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
91
|
| Line is longer than 80 characters. |
95
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
102
|
| Line has trailing spaces. |
106
|
| Method 'storeConfiguration' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Missing a Javadoc comment. |
107
|
| Parameter conf should be final. |
107
|
| 'conf' hides a field. |
107
|
| Line is longer than 80 characters. |
109
|
| Line has trailing spaces. |
111
|
gov/bnl/gums/GUMS.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
14
|
| Missing a Javadoc comment. |
23
|
| 'public' modifier out of order with the JLS suggestions. |
23
|
| Name 'siteAdminLog' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
| Missing a Javadoc comment. |
24
|
| 'public' modifier out of order with the JLS suggestions. |
24
|
| Name 'resourceAdminLog' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
24
|
| Missing a Javadoc comment. |
25
|
| 'private' modifier out of order with the JLS suggestions. |
25
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| 'private' modifier out of order with the JLS suggestions. |
26
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Variable 'confStore' must be private and have accessor methods. |
30
|
| Missing a Javadoc comment. |
31
|
| Line has trailing spaces. |
32
|
| Line is longer than 80 characters. |
37
|
| Line has trailing spaces. |
39
|
| Line has trailing spaces. |
42
|
| Missing a Javadoc comment. |
43
|
| Parameter confStore should be final. |
43
|
| 'confStore' hides a field. |
43
|
| Line is longer than 80 characters. |
46
|
| Line has trailing spaces. |
48
|
| Line has trailing spaces. |
51
|
| Parameter conf should be final. |
53
|
| 'conf' hides a field. |
53
|
| Expected @param tag for 'conf'. |
53
|
| Line has trailing spaces. |
56
|
| Missing a Javadoc comment. |
57
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
68
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
72
|
| Line is longer than 80 characters. |
77
|
| '*' is not preceded with whitespace. |
77
|
| '*' is not followed by whitespace. |
77
|
| '60' is a magic number. |
77
|
| '*' is not preceded with whitespace. |
77
|
| '*' is not followed by whitespace. |
77
|
| '1000' is a magic number. |
77
|
| Line is longer than 80 characters. |
78
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
83
|
| Method 'getResourceManager' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Line has trailing spaces. |
96
|
| Line has trailing spaces. |
101
|
| Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
104
|
| 'if' construct must use '{}'s. |
105
|
| Line has trailing spaces. |
108
|
| Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Parameter conf should be final. |
115
|
| 'conf' hides a field. |
115
|
| 'if' construct must use '{}'s. |
117
|
gov/bnl/gums/GecosAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
10
|
| Line is longer than 80 characters. |
13
|
| Line has trailing spaces. |
20
|
| Line is longer than 80 characters. |
21
|
| Missing a Javadoc comment. |
27
|
| 'private' modifier out of order with the JLS suggestions. |
27
|
| Line has trailing spaces. |
28
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Missing a Javadoc comment. |
29
|
| Parameter userDN should be final. |
29
|
| Line is longer than 80 characters. |
32
|
| Line has trailing spaces. |
35
|
| Missing a Javadoc comment. |
36
|
| Parameter certificateSubject should be final. |
36
|
| '3' is a magic number. |
37
|
| Name 'CN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
38
|
| Line has trailing spaces. |
39
|
| Line has trailing spaces. |
45
|
| '-' is not preceded with whitespace. |
49
|
| '-' is not followed by whitespace. |
49
|
| '-' is not preceded with whitespace. |
52
|
| '-' is not followed by whitespace. |
52
|
| Line has trailing spaces. |
53
|
| Line is longer than 80 characters. |
54
|
| Line has trailing spaces. |
57
|
| Missing a Javadoc comment. |
58
|
| Parameter possibleSurname should be final. |
58
|
| Line has trailing spaces. |
65
|
| Line has trailing spaces. |
68
|
| Missing a Javadoc comment. |
69
|
| Missing a Javadoc comment. |
70
|
| '+' is not followed by whitespace. |
75
|
| Line is longer than 80 characters. |
78
|
| '+' is not followed by whitespace. |
78
|
| Line has trailing spaces. |
88
|
| Expected an @return tag. |
92
|
| Line has trailing spaces. |
93
|
| Expected an @return tag. |
98
|
gov/bnl/gums/GecosLdapAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
24
|
| 'private' modifier out of order with the JLS suggestions. |
24
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
26
|
| Line has trailing spaces. |
27
|
| Method 'getJndiLdapUrl' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Line has trailing spaces. |
35
|
| Method 'setJndiLdapUrl' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Parameter jndiLdapUrl should be final. |
40
|
| 'jndiLdapUrl' hides a field. |
40
|
| Line has trailing spaces. |
43
|
| Missing a Javadoc comment. |
44
|
| Line is longer than 80 characters. |
47
|
| ',' is not followed by whitespace. |
47
|
| Method 'createMap' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Missing a Javadoc comment. |
51
|
| '5' is a magic number. |
53
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
72
|
| '+' is not preceded with whitespace. |
78
|
| '+' is not followed by whitespace. |
78
|
| '100' is a magic number. |
81
|
| '+' is not preceded with whitespace. |
86
|
| '+' is not followed by whitespace. |
86
|
| '100' is a magic number. |
89
|
| Line is longer than 80 characters. |
96
|
| Method 'mapName' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Missing a Javadoc comment. |
101
|
gov/bnl/gums/GecosMap.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
34
|
| Line has trailing spaces. |
35
|
| Method 'findAccount' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Parameter name should be final. |
36
|
| Parameter surname should be final. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| Line is longer than 80 characters. |
39
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
64
|
| '+' should be on a new line. |
64
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
74
|
| '+' should be on a new line. |
74
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
79
|
| '+' should be on a new line. |
79
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
88
|
| Line is longer than 80 characters. |
89
|
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
93
|
| Line is longer than 80 characters. |
97
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
109
|
| Line has trailing spaces. |
115
|
| Missing a Javadoc comment. |
116
|
| Missing a Javadoc comment. |
117
|
| '60' is a magic number. |
117
|
| '*' is not preceded with whitespace. |
117
|
| '*' is not followed by whitespace. |
117
|
| '60' is a magic number. |
117
|
| '*' is not preceded with whitespace. |
117
|
| '*' is not followed by whitespace. |
117
|
| '1000' is a magic number. |
117
|
| Method 'isValid' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Missing a Javadoc comment. |
118
|
| 'if' construct must use '{}'s. |
119
|
| 'if' construct must use '{}'s. |
120
|
| Line is longer than 80 characters. |
120
|
| Line has trailing spaces. |
123
|
| Missing a Javadoc comment. |
124
|
| Parameter gecos should be final. |
124
|
| 'if' construct must use '{}'s. |
131
|
| Line has trailing spaces. |
134
|
| Missing a Javadoc comment. |
135
|
| Parameter gecos should be final. |
135
|
| 'if' construct must use '{}'s. |
142
|
| '+' is not preceded with whitespace. |
143
|
| '+' is not followed by whitespace. |
143
|
| Line has trailing spaces. |
145
|
| Method 'addEntry' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Missing a Javadoc comment. |
146
|
| Parameter username should be final. |
146
|
| Parameter gecos should be final. |
146
|
| Line is longer than 80 characters. |
149
|
| Line has trailing spaces. |
159
|
| Method 'printMaps' is not designed for extension - needs to be abstract, final or empty. |
160
|
| Missing a Javadoc comment. |
160
|
| Parameter out should be final. |
160
|
| '15' is a magic number. |
171
|
| '30' is a magic number. |
175
|
| '15' is a magic number. |
179
|
| Line has trailing spaces. |
185
|
| Missing a Javadoc comment. |
186
|
| Parameter out should be final. |
186
|
| Parameter map should be final. |
186
|
| Parameter offset should be final. |
186
|
| Line has trailing spaces. |
196
|
| Method 'getExpiration' is not designed for extension - needs to be abstract, final or empty. |
206
|
| Method 'setExpiration' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Parameter expiration should be final. |
215
|
| 'expiration' hides a field. |
215
|
| Line has trailing spaces. |
219
|
gov/bnl/gums/GecosNisAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
24
|
| 'private' modifier out of order with the JLS suggestions. |
24
|
| Missing a Javadoc comment. |
26
|
| Line has trailing spaces. |
27
|
| Method 'getJndiNisUrl' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Line has trailing spaces. |
35
|
| Method 'setJndiNisUrl' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Parameter jndiNisUrl should be final. |
40
|
| 'jndiNisUrl' hides a field. |
40
|
| Line has trailing spaces. |
43
|
| Expected an @return tag. |
46
|
| Line is longer than 80 characters. |
49
|
| ',' is not followed by whitespace. |
49
|
| Line has trailing spaces. |
52
|
| Method 'createMap' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| '5' is a magic number. |
55
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
74
|
| '+' is not preceded with whitespace. |
80
|
| '+' is not followed by whitespace. |
80
|
| '100' is a magic number. |
83
|
| '+' is not preceded with whitespace. |
88
|
| '+' is not followed by whitespace. |
88
|
| '100' is a magic number. |
91
|
| Line is longer than 80 characters. |
98
|
| Method 'mapName' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Missing a Javadoc comment. |
103
|
gov/bnl/gums/GridUser.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
12
|
| Missing a Javadoc comment. |
17
|
| Line has trailing spaces. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
27
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
31
|
| Parameter userDN should be final. |
33
|
| Parameter fqan should be final. |
33
|
| 'if' construct must use '{}'s. |
35
|
| Line has trailing spaces. |
38
|
| Line is longer than 80 characters. |
41
|
| Method 'getCertificateDN' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Line has trailing spaces. |
46
|
| Line is longer than 80 characters. |
49
|
| Method 'setCertificateDN' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Parameter certificateDN should be final. |
51
|
| 'certificateDN' hides a field. |
51
|
| Line has trailing spaces. |
54
|
| Line is longer than 80 characters. |
57
|
| Method 'getVoFQAN' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Line has trailing spaces. |
62
|
| Line is longer than 80 characters. |
65
|
| Method 'setVoFQAN' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Parameter voFQAN should be final. |
67
|
| 'voFQAN' hides a field. |
67
|
| Line has trailing spaces. |
70
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Line has trailing spaces. |
84
|
| Line is longer than 80 characters. |
86
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Parameter obj should be final. |
90
|
| Line is longer than 80 characters. |
92
|
| Avoid inline conditionals. |
92
|
| Line is longer than 80 characters. |
98
|
| Avoid inline conditionals. |
98
|
| Line has trailing spaces. |
109
|
| Line is longer than 80 characters. |
112
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Line has trailing spaces. |
120
|
gov/bnl/gums/GroupAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
20
|
| Line has trailing spaces. |
21
|
| Missing a Javadoc comment. |
22
|
| Line has trailing spaces. |
23
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter userDN should be final. |
24
|
| Line has trailing spaces. |
25
|
| Line has trailing spaces. |
29
|
| Line has trailing spaces. |
32
|
| Method 'setGroupName' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Parameter groupName should be final. |
37
|
| 'groupName' hides a field. |
37
|
| Line is longer than 80 characters. |
38
|
| Line has trailing spaces. |
41
|
| Method 'getGroupName' is not designed for extension - needs to be abstract, final or empty. |
46
|
gov/bnl/gums/GroupMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
16
|
| Line has trailing spaces. |
22
|
| Line has trailing spaces. |
27
|
| Line has trailing spaces. |
32
|
| Line has trailing spaces. |
37
|
| Line has trailing spaces. |
47
|
| Method 'getGroup' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Line has trailing spaces. |
54
|
| Line has trailing spaces. |
55
|
| Method 'setGroup' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter group should be final. |
60
|
| 'group' hides a field. |
60
|
| Line has trailing spaces. |
62
|
| Line has trailing spaces. |
63
|
| Method 'getMapper' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Line has trailing spaces. |
71
|
| Method 'setMapper' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Parameter mapper should be final. |
76
|
| 'mapper' hides a field. |
76
|
| Line has trailing spaces. |
79
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Line has trailing spaces. |
87
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Parameter name should be final. |
92
|
| 'name' hides a field. |
92
|
| Line has trailing spaces. |
95
|
| Method 'getAccountingVo' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Line has trailing spaces. |
104
|
| Method 'setAccountingVo' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Parameter accountingVo should be final. |
109
|
| 'accountingVo' hides a field. |
109
|
| Method 'getAccountingDesc' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Method 'setAccountingDesc' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter accountingDesc should be final. |
127
|
| 'accountingDesc' hides a field. |
127
|
| Line has trailing spaces. |
131
|
gov/bnl/gums/HostGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Line has trailing spaces. |
15
|
gov/bnl/gums/LDAPGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Using the '.*' form of import should be avoided - javax.naming.*. |
10
|
| Using the '.*' form of import should be avoided - javax.naming.directory.*. |
11
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
12
|
| Line has trailing spaces. |
18
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Line has trailing spaces. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Line has trailing spaces. |
37
|
| Missing a Javadoc comment. |
37
|
| Line has trailing spaces. |
38
|
| Method 'getMemberList' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Line has trailing spaces. |
42
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Line has trailing spaces. |
46
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Missing a Javadoc comment. |
47
|
| Parameter name should be final. |
47
|
| 'name' hides a field. |
47
|
| Line has trailing spaces. |
50
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Missing a Javadoc comment. |
51
|
| Parameter user should be final. |
51
|
| Line has trailing spaces. |
54
|
| Method 'updateMembers' is not designed for extension - needs to be abstract, final or empty. |
55
|
| Missing a Javadoc comment. |
55
|
| Line has trailing spaces. |
58
|
| Missing a Javadoc comment. |
59
|
| Missing a Javadoc comment. |
60
|
| Line has trailing spaces. |
61
|
| Line is longer than 80 characters. |
63
|
| ',' is not followed by whitespace. |
68
|
| '+' is not preceded with whitespace. |
68
|
| '+' is not followed by whitespace. |
68
|
| Line is longer than 80 characters. |
69
|
| ',' is not followed by whitespace. |
69
|
| Line is longer than 80 characters. |
70
|
| '+' should be on a new line. |
70
|
| Line is longer than 80 characters. |
73
|
| Line has trailing spaces. |
74
|
| '+' is not preceded with whitespace. |
76
|
| '+' is not followed by whitespace. |
76
|
| Line is longer than 80 characters. |
83
|
| '+' is not preceded with whitespace. |
85
|
| '+' is not followed by whitespace. |
85
|
| Line is longer than 80 characters. |
92
|
| Line has trailing spaces. |
104
|
| Missing a Javadoc comment. |
105
|
| Parameter rootCtx should be final. |
105
|
| Line is longer than 80 characters. |
109
|
| Line is longer than 80 characters. |
118
|
| Line has trailing spaces. |
122
|
| Line is longer than 80 characters. |
123
|
| Missing a Javadoc comment. |
123
|
| Parameter rootCtx should be final. |
123
|
| Parameter members should be final. |
123
|
| Line is longer than 80 characters. |
128
|
| Line is longer than 80 characters. |
133
|
| Line is longer than 80 characters. |
139
|
| Line has trailing spaces. |
143
|
| Method 'retrievePeopleMap' is not designed for extension - needs to be abstract, final or empty. |
144
|
| Missing a Javadoc comment. |
144
|
| Parameter ldap should be final. |
144
|
| Line is longer than 80 characters. |
145
|
| Line has trailing spaces. |
154
|
| '8' is a magic number. |
157
|
| Line has trailing spaces. |
164
|
| Method 'getServer' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Line has trailing spaces. |
172
|
| Method 'setServer' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Parameter server should be final. |
177
|
| 'server' hides a field. |
177
|
| Line has trailing spaces. |
180
|
| Line is longer than 80 characters. |
183
|
| Method 'getQuery' is not designed for extension - needs to be abstract, final or empty. |
185
|
| Line has trailing spaces. |
188
|
| Line is longer than 80 characters. |
191
|
| Method 'setQuery' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Parameter query should be final. |
193
|
| 'query' hides a field. |
193
|
| Line has trailing spaces. |
196
|
| Method 'getPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
197
|
| Missing a Javadoc comment. |
197
|
| Line has trailing spaces. |
200
|
| Line is longer than 80 characters. |
201
|
| Method 'setPersistence' is not designed for extension - needs to be abstract, final or empty. |
201
|
| Missing a Javadoc comment. |
201
|
| Parameter persistanceFactory should be final. |
201
|
| 'persistanceFactory' hides a field. |
201
|
| Parameter name should be final. |
201
|
| 'name' hides a field. |
201
|
| Line has trailing spaces. |
206
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
207
|
| Missing a Javadoc comment. |
207
|
| Line has trailing spaces. |
210
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Missing a Javadoc comment. |
211
|
| '+' is not preceded with whitespace. |
212
|
| '+' is not followed by whitespace. |
212
|
| '+' is not preceded with whitespace. |
212
|
| '+' is not followed by whitespace. |
212
|
| '+' is not preceded with whitespace. |
212
|
| '+' is not followed by whitespace. |
212
|
| Line has trailing spaces. |
214
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Missing a Javadoc comment. |
215
|
| Parameter obj should be final. |
215
|
| Line is longer than 80 characters. |
218
|
| Avoid inline conditionals. |
218
|
| '&&' should be on a new line. |
218
|
| Line has trailing spaces. |
219
|
| Line is longer than 80 characters. |
219
|
| Avoid inline conditionals. |
219
|
| '&&' should be on a new line. |
219
|
| Line has trailing spaces. |
220
|
| Avoid inline conditionals. |
220
|
| '&&' should be on a new line. |
220
|
| Line is longer than 80 characters. |
221
|
| Avoid inline conditionals. |
221
|
| Line has trailing spaces. |
227
|
gov/bnl/gums/ManualAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Line has trailing spaces. |
23
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter userDN should be final. |
24
|
| Line has trailing spaces. |
27
|
| Method 'createMapping' is not designed for extension - needs to be abstract, final or empty. |
28
|
| Missing a Javadoc comment. |
28
|
| Parameter userDN should be final. |
28
|
| Parameter account should be final. |
28
|
| Line has trailing spaces. |
31
|
| Method 'removeMapping' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| Parameter userDN should be final. |
32
|
| Line has trailing spaces. |
35
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Line has trailing spaces. |
39
|
| Method 'getPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Missing a Javadoc comment. |
40
|
| Line has trailing spaces. |
43
|
| Line is longer than 80 characters. |
44
|
| Method 'setPersistence' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter persistanceFactory should be final. |
44
|
| 'persistanceFactory' hides a field. |
44
|
| Parameter name should be final. |
44
|
| 'name' hides a field. |
44
|
| Line has trailing spaces. |
49
|
gov/bnl/gums/ManualAccountMapperDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
10
|
gov/bnl/gums/ManualUserGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Line has trailing spaces. |
22
|
| Method 'getMemberList' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Line has trailing spaces. |
26
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
30
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter user should be final. |
31
|
| Line has trailing spaces. |
34
|
| Missing a Javadoc comment. |
35
|
| Line has trailing spaces. |
37
|
| Method 'addMember' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter user should be final. |
38
|
| Line has trailing spaces. |
41
|
| Method 'removeMember' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter user should be final. |
42
|
| Line has trailing spaces. |
45
|
| Method 'getPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Line has trailing spaces. |
49
|
| Line is longer than 80 characters. |
50
|
| Method 'setPersistence' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter persistenceFactory should be final. |
50
|
| 'persistenceFactory' hides a field. |
50
|
| Parameter name should be final. |
50
|
| 'name' hides a field. |
50
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Missing a Javadoc comment. |
56
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
60
|
| Line has trailing spaces. |
63
|
gov/bnl/gums/ManualUserGroupDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Missing a Javadoc comment. |
22
|
| Missing a Javadoc comment. |
23
|
gov/bnl/gums/MySQLPersistenceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.sql.*. |
9
|
| Using the '.*' form of import should be avoided - java.util.*. |
11
|
| Missing a Javadoc comment. |
25
|
| Line has trailing spaces. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| Line has trailing spaces. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Line is longer than 80 characters. |
35
|
| Line is longer than 80 characters. |
38
|
| Line has trailing spaces. |
42
|
| Missing a Javadoc comment. |
43
|
| Parameter conn should be final. |
43
|
| Line is longer than 80 characters. |
45
|
| Line has trailing spaces. |
47
|
| Missing a Javadoc comment. |
48
|
| Line is longer than 80 characters. |
49
|
| Line has trailing spaces. |
58
|
| Method 'setConnectionFromDbProperties' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Line is longer than 80 characters. |
63
|
| Line has trailing spaces. |
66
|
| Missing a Javadoc comment. |
67
|
| Line is longer than 80 characters. |
73
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
77
|
| Line is longer than 80 characters. |
84
|
| Line has trailing spaces. |
87
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Line has trailing spaces. |
91
|
| Method 'setConnection' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Missing a Javadoc comment. |
92
|
| Parameter conn should be final. |
92
|
| Line has trailing spaces. |
95
|
| Method 'retrieveUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| Parameter groupName should be final. |
96
|
| Line has trailing spaces. |
99
|
| Method 'retrieveManualUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Missing a Javadoc comment. |
100
|
| Parameter groupName should be final. |
100
|
| Line has trailing spaces. |
103
|
| Method 'retrieveManualAccountMapperDB' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Missing a Javadoc comment. |
104
|
| Parameter name should be final. |
104
|
| 'name' hides a field. |
104
|
| Line has trailing spaces. |
107
|
| Method 'retrieveAccountPoolMapperDB' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Missing a Javadoc comment. |
108
|
| Parameter name should be final. |
108
|
| 'name' hides a field. |
108
|
| Line has trailing spaces. |
112
|
| Missing a Javadoc comment. |
113
|
| Line is longer than 80 characters. |
114
|
| Missing a Javadoc comment. |
114
|
| Parameter conn should be final. |
114
|
| Parameter sql should be final. |
114
|
| Line is longer than 80 characters. |
120
|
| Line has trailing spaces. |
128
|
| Missing a Javadoc comment. |
129
|
| Parameter userDN should be final. |
129
|
| Parameter groupName should be final. |
129
|
| Line is longer than 80 characters. |
131
|
| '+' is not followed by whitespace. |
131
|
| Line is longer than 80 characters. |
136
|
| Line has trailing spaces. |
137
|
| Line has trailing spaces. |
140
|
| Line has trailing spaces. |
142
|
| Line is longer than 80 characters. |
145
|
| Missing a Javadoc comment. |
151
|
| Parameter userDN should be final. |
151
|
| Parameter fqan should be final. |
151
|
| Parameter groupName should be final. |
151
|
| Line is longer than 80 characters. |
153
|
| '+' is not followed by whitespace. |
153
|
| Line is longer than 80 characters. |
158
|
| Line has trailing spaces. |
159
|
| '3' is a magic number. |
162
|
| Line has trailing spaces. |
163
|
| Line is longer than 80 characters. |
167
|
| Line has trailing spaces. |
172
|
| Missing a Javadoc comment. |
173
|
| Parameter DN should be final. |
173
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
173
|
| Parameter groupName should be final. |
173
|
| Line is longer than 80 characters. |
177
|
| '+' should be on a new line. |
177
|
| '+' should be on a new line. |
178
|
| Line is longer than 80 characters. |
179
|
| Line has trailing spaces. |
180
|
| Line has trailing spaces. |
183
|
| 'if' construct must use '{}'s. |
185
|
| Line is longer than 80 characters. |
190
|
| Missing a Javadoc comment. |
196
|
| Parameter DN should be final. |
196
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
196
|
| Parameter groupName should be final. |
196
|
| Parameter fqan should be final. |
196
|
| Line is longer than 80 characters. |
200
|
| '+' should be on a new line. |
200
|
| '+' should be on a new line. |
201
|
| Line is longer than 80 characters. |
202
|
| Line has trailing spaces. |
203
|
| '3' is a magic number. |
206
|
| Line has trailing spaces. |
207
|
| 'if' construct must use '{}'s. |
209
|
| Line is longer than 80 characters. |
214
|
| Line has trailing spaces. |
219
|
| Missing a Javadoc comment. |
220
|
| Line has trailing spaces. |
221
|
| Missing a Javadoc comment. |
222
|
| Line has trailing spaces. |
223
|
| Missing a Javadoc comment. |
224
|
| Missing a Javadoc comment. |
225
|
| Line has trailing spaces. |
226
|
| Missing a Javadoc comment. |
227
|
| Parameter groupName should be final. |
227
|
| 'groupName' hides a field. |
227
|
| Line has trailing spaces. |
230
|
| Missing a Javadoc comment. |
231
|
| Parameter user should be final. |
231
|
| Line is longer than 80 characters. |
235
|
| Line has trailing spaces. |
238
|
| Missing a Javadoc comment. |
239
|
| Parameter members should be final. |
239
|
| Line is longer than 80 characters. |
241
|
| Line has trailing spaces. |
260
|
| Missing a Javadoc comment. |
261
|
| Line is longer than 80 characters. |
264
|
| '+' should be on a new line. |
264
|
| Line is longer than 80 characters. |
265
|
| '+' should be on a new line. |
265
|
| Line has trailing spaces. |
267
|
| Line has trailing spaces. |
269
|
| Line is longer than 80 characters. |
273
|
| Line has trailing spaces. |
275
|
| Line is longer than 80 characters. |
279
|
| Line has trailing spaces. |
284
|
| Missing a Javadoc comment. |
285
|
| Line has trailing spaces. |
288
|
| Missing a Javadoc comment. |
289
|
| Line has trailing spaces. |
292
|
| Missing a Javadoc comment. |
293
|
| Parameter user should be final. |
293
|
| Line is longer than 80 characters. |
297
|
| Line has trailing spaces. |
300
|
| Missing a Javadoc comment. |
301
|
| Parameter user should be final. |
301
|
| Line is longer than 80 characters. |
304
|
| '+' should be on a new line. |
304
|
| Line is longer than 80 characters. |
305
|
| Line has trailing spaces. |
306
|
| Line is longer than 80 characters. |
307
|
| '+' should be on a new line. |
307
|
| Line is longer than 80 characters. |
308
|
| Line has trailing spaces. |
309
|
| Line is longer than 80 characters. |
311
|
| '3' is a magic number. |
317
|
| Line has trailing spaces. |
320
|
| Line is longer than 80 characters. |
323
|
| Line has trailing spaces. |
328
|
| Line has trailing spaces. |
330
|
| Missing a Javadoc comment. |
331
|
| 'cast' is not followed by whitespace. |
331
|
| Line has trailing spaces. |
334
|
| Line is longer than 80 characters. |
335
|
| Method 'mapAccountToUser' is not designed for extension - needs to be abstract, final or empty. |
335
|
| Missing a Javadoc comment. |
335
|
| Parameter userGroup should be final. |
335
|
| Parameter user should be final. |
335
|
| Parameter account should be final. |
335
|
| Line is longer than 80 characters. |
338
|
| Line has trailing spaces. |
339
|
| '3' is a magic number. |
342
|
| Line has trailing spaces. |
343
|
| Method 'removeMappings' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Missing a Javadoc comment. |
353
|
| Parameter user should be final. |
353
|
| Parameter userGroup should be final. |
353
|
| Line is longer than 80 characters. |
356
|
| '+' should be on a new line. |
356
|
| '+' should be on a new line. |
357
|
| '+' should be on a new line. |
358
|
| Line has trailing spaces. |
360
|
| Line has trailing spaces. |
363
|
| Line is longer than 80 characters. |
367
|
| Line has trailing spaces. |
372
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
373
|
| Missing a Javadoc comment. |
373
|
| Line has trailing spaces. |
376
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
377
|
| Missing a Javadoc comment. |
377
|
| Parameter name should be final. |
377
|
| 'name' hides a field. |
377
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
381
|
| Missing a Javadoc comment. |
381
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
385
|
| Missing a Javadoc comment. |
385
|
| Parameter properties should be final. |
385
|
| 'properties' hides a field. |
385
|
| Line has trailing spaces. |
388
|
| Missing a Javadoc comment. |
389
|
| Line has trailing spaces. |
390
|
| Missing a Javadoc comment. |
391
|
| Variable 'userGroup' must be private and have accessor methods. |
391
|
| Line has trailing spaces. |
392
|
| Missing a Javadoc comment. |
393
|
| Parameter userGroup should be final. |
393
|
| 'userGroup' hides a field. |
393
|
| Line has trailing spaces. |
396
|
| Missing a Javadoc comment. |
397
|
| Parameter userDN should be final. |
397
|
| Parameter account should be final. |
397
|
| Line has trailing spaces. |
400
|
| Missing a Javadoc comment. |
401
|
| Parameter userDN should be final. |
401
|
| Line has trailing spaces. |
404
|
| Missing a Javadoc comment. |
405
|
| Parameter userDN should be final. |
405
|
| Line is longer than 80 characters. |
408
|
| '+' should be on a new line. |
408
|
| '+' should be on a new line. |
409
|
| '+' should be on a new line. |
410
|
| '+' should be on a new line. |
411
|
| Line has trailing spaces. |
413
|
| Line has trailing spaces. |
416
|
| 'if' construct must use '{}'s. |
418
|
| Line has trailing spaces. |
419
|
| Line is longer than 80 characters. |
423
|
| Line has trailing spaces. |
427
|
| Line has trailing spaces. |
429
|
| Line has trailing spaces. |
431
|
| Missing a Javadoc comment. |
432
|
| Line has trailing spaces. |
433
|
| Missing a Javadoc comment. |
434
|
| Variable 'userGroup' must be private and have accessor methods. |
434
|
| Line has trailing spaces. |
435
|
| Missing a Javadoc comment. |
436
|
| Parameter userGroup should be final. |
436
|
| 'userGroup' hides a field. |
436
|
| Line has trailing spaces. |
439
|
| Missing a Javadoc comment. |
440
|
| Parameter account should be final. |
440
|
| Line is longer than 80 characters. |
442
|
| Line is longer than 80 characters. |
446
|
| Line has trailing spaces. |
447
|
| Line has trailing spaces. |
450
|
| Line has trailing spaces. |
459
|
| Missing a Javadoc comment. |
460
|
| Parameter account should be final. |
460
|
| Line is longer than 80 characters. |
463
|
| '+' should be on a new line. |
463
|
| '+' should be on a new line. |
464
|
| Line has trailing spaces. |
466
|
| Line has trailing spaces. |
469
|
| 'if' construct must use '{}'s. |
471
|
| Line has trailing spaces. |
472
|
| Line is longer than 80 characters. |
476
|
| Line has trailing spaces. |
481
|
| Missing a Javadoc comment. |
482
|
| Parameter userDN should be final. |
482
|
| 'if' construct must use '{}'s. |
484
|
| Line is longer than 80 characters. |
487
|
| '+' should be on a new line. |
487
|
| '+' should be on a new line. |
488
|
| '+' should be on a new line. |
489
|
| Line is longer than 80 characters. |
492
|
| Line is longer than 80 characters. |
493
|
| '3' is a magic number. |
494
|
| '4' is a magic number. |
495
|
| '5' is a magic number. |
496
|
| Line is longer than 80 characters. |
502
|
| Line has trailing spaces. |
507
|
| Missing a Javadoc comment. |
508
|
| Line is longer than 80 characters. |
511
|
| '+' should be on a new line. |
511
|
| '+' should be on a new line. |
512
|
| Line is longer than 80 characters. |
513
|
| Line has trailing spaces. |
514
|
| Line has trailing spaces. |
516
|
| 'if' construct must use '{}'s. |
518
|
| Line has trailing spaces. |
519
|
| Line is longer than 80 characters. |
523
|
| Line has trailing spaces. |
528
|
| Missing a Javadoc comment. |
529
|
| Parameter userDN should be final. |
529
|
| Line is longer than 80 characters. |
532
|
| '+' should be on a new line. |
532
|
| '+' should be on a new line. |
533
|
| Line has trailing spaces. |
535
|
| Line has trailing spaces. |
538
|
| 'if' construct must use '{}'s. |
540
|
| Line has trailing spaces. |
541
|
| Line has trailing spaces. |
543
|
| Line is longer than 80 characters. |
544
|
| '+' should be on a new line. |
544
|
| '+' should be on a new line. |
545
|
| '+' should be on a new line. |
546
|
| Line has trailing spaces. |
548
|
| Line is longer than 80 characters. |
549
|
| '3' is a magic number. |
551
|
| Line has trailing spaces. |
552
|
| Line has trailing spaces. |
554
|
| Line is longer than 80 characters. |
558
|
| Line has trailing spaces. |
563
|
| Missing a Javadoc comment. |
564
|
| Line is longer than 80 characters. |
567
|
| '+' should be on a new line. |
567
|
| '+' should be on a new line. |
568
|
| Line has trailing spaces. |
570
|
| Line has trailing spaces. |
572
|
| Line has trailing spaces. |
580
|
| Line is longer than 80 characters. |
584
|
| Line has trailing spaces. |
589
|
| Missing a Javadoc comment. |
590
|
| Parameter date should be final. |
590
|
| Line is longer than 80 characters. |
593
|
| '+' should be on a new line. |
593
|
| '+' should be on a new line. |
594
|
| Line has trailing spaces. |
596
|
| Line is longer than 80 characters. |
598
|
| Line has trailing spaces. |
599
|
| Line has trailing spaces. |
607
|
| Line is longer than 80 characters. |
611
|
| Line has trailing spaces. |
616
|
| Missing a Javadoc comment. |
617
|
| Parameter user should be final. |
617
|
| Line is longer than 80 characters. |
620
|
| '+' should be on a new line. |
620
|
| '+' should be on a new line. |
621
|
| '+' should be on a new line. |
622
|
| Line has trailing spaces. |
624
|
| Line has trailing spaces. |
627
|
| Line is longer than 80 characters. |
631
|
| Line has trailing spaces. |
636
|
gov/bnl/gums/NISAccountMapper.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
10
|
| Line is longer than 80 characters. |
13
|
| Line has trailing spaces. |
17
|
| Line is longer than 80 characters. |
18
|
| Missing a Javadoc comment. |
24
|
| Variable 'log' must be private and have accessor methods. |
24
|
| Missing a Javadoc comment. |
25
|
| Variable 'adminLog' must be private and have accessor methods. |
25
|
| Line has trailing spaces. |
26
|
| Line has trailing spaces. |
31
|
| First sentence should end with a period. |
32
|
| Line is longer than 80 characters. |
34
|
| Line has trailing spaces. |
36
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter userDN should be final. |
37
|
| Line is longer than 80 characters. |
39
|
| Line has trailing spaces. |
41
|
| Missing a Javadoc comment. |
42
|
| Parameter certificateSubject should be final. |
42
|
| '3' is a magic number. |
43
|
| Name 'CN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
| Line has trailing spaces. |
45
|
| Line has trailing spaces. |
51
|
| '-' is not preceded with whitespace. |
55
|
| '-' is not followed by whitespace. |
55
|
| '-' is not preceded with whitespace. |
58
|
| '-' is not followed by whitespace. |
58
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
60
|
| Line has trailing spaces. |
63
|
| Missing a Javadoc comment. |
64
|
| Parameter possibleSurname should be final. |
64
|
| Line has trailing spaces. |
71
|
| Line has trailing spaces. |
74
|
| Method 'getJndiNisUrl' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Line has trailing spaces. |
82
|
| Method 'setJndiNisUrl' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Parameter jndiNisUrl should be final. |
87
|
| 'jndiNisUrl' hides a field. |
87
|
| Line has trailing spaces. |
90
|
| Missing a Javadoc comment. |
91
|
| Missing a Javadoc comment. |
92
|
| Parameter jndiNisUrl should be final. |
92
|
| 'jndiNisUrl' hides a field. |
92
|
| '+' is not followed by whitespace. |
95
|
| Line has trailing spaces. |
103
|
gov/bnl/gums/NisClient.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
39
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
41
|
| Missing a Javadoc comment. |
42
|
| Line has trailing spaces. |
43
|
| Missing a Javadoc comment. |
44
|
| Line has trailing spaces. |
45
|
| First sentence should end with a period. |
46
|
| Parameter nisJndiUrl should be final. |
47
|
| 'nisJndiUrl' hides a field. |
47
|
| Expected @param tag for 'nisJndiUrl'. |
47
|
| Line has trailing spaces. |
50
|
| Method 'findAccount' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Missing a Javadoc comment. |
51
|
| Parameter name should be final. |
51
|
| Parameter surname should be final. |
51
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
56
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
67
|
| Line is longer than 80 characters. |
70
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
83
|
| '+' should be on a new line. |
83
|
| Line is longer than 80 characters. |
84
|
| Line is longer than 80 characters. |
85
|
| Line is longer than 80 characters. |
93
|
| '+' should be on a new line. |
93
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
98
|
| '+' should be on a new line. |
98
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
107
|
| Line is longer than 80 characters. |
108
|
| Line is longer than 80 characters. |
111
|
| Line is longer than 80 characters. |
112
|
| Line is longer than 80 characters. |
116
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
119
|
| Line is longer than 80 characters. |
128
|
| Line has trailing spaces. |
137
|
| Missing a Javadoc comment. |
138
|
| Line is longer than 80 characters. |
141
|
| ',' is not followed by whitespace. |
141
|
| Line has trailing spaces. |
144
|
| Missing a Javadoc comment. |
145
|
| Line is longer than 80 characters. |
154
|
| Line has trailing spaces. |
163
|
| Missing a Javadoc comment. |
164
|
| Missing a Javadoc comment. |
165
|
| 'if' construct must use '{}'s. |
166
|
| 'if' construct must use '{}'s. |
167
|
| Line is longer than 80 characters. |
167
|
| '60' is a magic number. |
167
|
| '*' is not preceded with whitespace. |
167
|
| '*' is not followed by whitespace. |
167
|
| '60' is a magic number. |
167
|
| '*' is not preceded with whitespace. |
167
|
| '*' is not followed by whitespace. |
167
|
| '1000' is a magic number. |
167
|
| Line has trailing spaces. |
170
|
| Missing a Javadoc comment. |
171
|
| Parameter jndiProperties should be final. |
171
|
| Parameter accountToGecos should be final. |
171
|
| 'accountToGecos' hides a field. |
171
|
| Parameter accountToName should be final. |
172
|
| 'accountToName' hides a field. |
172
|
| Parameter accountToSurname should be final. |
172
|
| 'accountToSurname' hides a field. |
172
|
| '5' is a magic number. |
173
|
| Line is longer than 80 characters. |
177
|
| Line is longer than 80 characters. |
183
|
| Line is longer than 80 characters. |
194
|
| Line is longer than 80 characters. |
203
|
| '+' is not preceded with whitespace. |
209
|
| '+' is not followed by whitespace. |
209
|
| '100' is a magic number. |
212
|
| '+' is not preceded with whitespace. |
217
|
| '+' is not followed by whitespace. |
217
|
| '100' is a magic number. |
220
|
| Line is longer than 80 characters. |
227
|
| Line has trailing spaces. |
230
|
| Missing a Javadoc comment. |
231
|
| Parameter gecos should be final. |
231
|
| 'if' construct must use '{}'s. |
238
|
| Line has trailing spaces. |
241
|
| Missing a Javadoc comment. |
242
|
| Parameter gecos should be final. |
242
|
| 'if' construct must use '{}'s. |
249
|
| '+' is not preceded with whitespace. |
250
|
| '+' is not followed by whitespace. |
250
|
| Line has trailing spaces. |
252
|
| Method 'printMaps' is not designed for extension - needs to be abstract, final or empty. |
253
|
| Missing a Javadoc comment. |
253
|
| Parameter out should be final. |
253
|
| '15' is a magic number. |
265
|
| '30' is a magic number. |
269
|
| '15' is a magic number. |
273
|
| Line has trailing spaces. |
279
|
| Missing a Javadoc comment. |
280
|
| Parameter out should be final. |
280
|
| Parameter map should be final. |
280
|
| Parameter offset should be final. |
280
|
| Line has trailing spaces. |
290
|
| Line has trailing spaces. |
293
|
gov/bnl/gums/PersistenceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
gov/bnl/gums/ReadWriteLock.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
17
|
| Missing a Javadoc comment. |
24
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
28
|
| Missing a Javadoc comment. |
29
|
| Parameter name should be final. |
29
|
| 'name' hides a field. |
29
|
| Line has trailing spaces. |
32
|
| Expected an @return tag. |
35
|
| Method 'isReadLocked' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Line has trailing spaces. |
38
|
| Expected an @return tag. |
41
|
| Method 'isWriteLocked' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Line has trailing spaces. |
44
|
| Method 'obtainWriteLock' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Line is longer than 80 characters. |
46
|
| Line has trailing spaces. |
47
|
| Line is longer than 80 characters. |
51
|
| Line has trailing spaces. |
60
|
| Line has trailing spaces. |
70
|
| Method 'releaseWriteLock' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Missing a Javadoc comment. |
71
|
| Line is longer than 80 characters. |
72
|
| '=' is not preceded with whitespace. |
73
|
| '=' is not followed by whitespace. |
73
|
| Line has trailing spaces. |
77
|
| Method 'obtainReadLock' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Missing a Javadoc comment. |
78
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
83
|
| Line has trailing spaces. |
89
|
| Line has trailing spaces. |
95
|
| Method 'releaseReadLock' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Missing a Javadoc comment. |
96
|
| Line is longer than 80 characters. |
97
|
| Line has trailing spaces. |
102
|
gov/bnl/gums/ResourceManager.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.io.*. |
9
|
| Using the '.*' form of import should be avoided - java.util.*. |
10
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
23
|
| Variable 'gums' must be private and have accessor methods. |
23
|
| Line has trailing spaces. |
24
|
| Parameter gums should be final. |
27
|
| 'gums' hides a field. |
27
|
| Expected @param tag for 'gums'. |
27
|
| Line has trailing spaces. |
30
|
| Method 'updateGroups' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Line has trailing spaces. |
37
|
| Missing a Javadoc comment. |
38
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
47
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
62
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
68
|
| Line has trailing spaces. |
71
|
| Expected an @return tag. |
74
|
| Method 'generateGridMapfile' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Parameter hostname should be final. |
74
|
| Expected @param tag for 'hostname'. |
74
|
| Line has trailing spaces. |
79
|
| Missing a Javadoc comment. |
80
|
| Parameter hostname should be final. |
80
|
| 'if' construct must use '{}'s. |
83
|
| Line has trailing spaces. |
87
|
| Missing a Javadoc comment. |
88
|
| Parameter conf should be final. |
88
|
| Parameter hostname should be final. |
88
|
| Line has trailing spaces. |
98
|
| Expected an @return tag. |
103
|
| Parameter group should be final. |
103
|
| Expected @param tag for 'group'. |
103
|
| Line has trailing spaces. |
106
|
| Line is longer than 80 characters. |
113
|
| Line has trailing spaces. |
114
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
119
|
| ')' is preceded with whitespace. |
122
|
| ')' is preceded with whitespace. |
123
|
| ')' is preceded with whitespace. |
124
|
| ')' is preceded with whitespace. |
125
|
| Line is longer than 80 characters. |
129
|
| Line has trailing spaces. |
137
|
| Missing a Javadoc comment. |
138
|
| Parameter o1 should be final. |
140
|
| Parameter o2 should be final. |
140
|
| Line is longer than 80 characters. |
143
|
| Line has trailing spaces. |
147
|
| Method 'generateGrid3UserVoMap' is not designed for extension - needs to be abstract, final or empty. |
148
|
| Missing a Javadoc comment. |
148
|
| Parameter hostname should be final. |
148
|
| 'if' construct must use '{}'s. |
151
|
| Line is longer than 80 characters. |
152
|
| Line has trailing spaces. |
155
|
| Line is longer than 80 characters. |
157
|
| Line is longer than 80 characters. |
158
|
| Line has trailing spaces. |
159
|
| Line has trailing spaces. |
164
|
| Line is longer than 80 characters. |
165
|
| Line has trailing spaces. |
170
|
| Line has trailing spaces. |
175
|
| Line has trailing spaces. |
177
|
| Line has trailing spaces. |
179
|
| Line is longer than 80 characters. |
185
|
| Line has trailing spaces. |
186
|
| Line is longer than 80 characters. |
190
|
| Line is longer than 80 characters. |
191
|
| Expected an @return tag. |
206
|
| Method 'map' is not designed for extension - needs to be abstract, final or empty. |
206
|
| Parameter hostname should be final. |
206
|
| Expected @param tag for 'hostname'. |
206
|
| Parameter user should be final. |
206
|
| Expected @param tag for 'user'. |
206
|
| Missing a Javadoc comment. |
212
|
| Parameter hostname should be final. |
212
|
| Parameter user should be final. |
212
|
| 'if' construct must use '{}'s. |
215
|
| Line is longer than 80 characters. |
221
|
| Line is longer than 80 characters. |
226
|
gov/bnl/gums/UserGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Line has trailing spaces. |
11
|
| Line has trailing spaces. |
18
|
| Unused @param tag for 'userDN'. |
21
|
| Expected @param tag for 'user'. |
24
|
| Line has trailing spaces. |
25
|
| Line has trailing spaces. |
39
|
| Line has trailing spaces. |
48
|
| Line is longer than 80 characters. |
52
|
gov/bnl/gums/UserGroupDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Line has trailing spaces. |
13
|
| Line is longer than 80 characters. |
23
|
| Line has trailing spaces. |
33
|
| First sentence should end with a period. |
41
|
| First sentence should end with a period. |
46
|
gov/bnl/gums/VOMSGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.net.*. |
9
|
| Using the '.*' form of import should be avoided - java.util.*. |
10
|
| Using the '.*' form of import should be avoided - org.edg.security.voms.service.admin.*. |
13
|
| Line has trailing spaces. |
15
|
| Line is longer than 80 characters. |
23
|
| Line has trailing spaces. |
24
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Line has trailing spaces. |
33
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Line is longer than 80 characters. |
39
|
| Missing a Javadoc comment. |
39
|
| Missing a Javadoc comment. |
40
|
| Line has trailing spaces. |
41
|
| Line has trailing spaces. |
46
|
| Line has trailing spaces. |
51
|
| Line has trailing spaces. |
56
|
| Line has trailing spaces. |
61
|
| Line has trailing spaces. |
66
|
| Line has trailing spaces. |
71
|
| Method 'getMemberList' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Missing a Javadoc comment. |
72
|
| Line has trailing spaces. |
75
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Missing a Javadoc comment. |
76
|
| Line has trailing spaces. |
79
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Parameter user should be final. |
80
|
| Line has trailing spaces. |
84
|
| Line has trailing spaces. |
94
|
| 'if' construct must use '{}'s. |
98
|
| Line has trailing spaces. |
102
|
| 'if' construct must use '{}'s. |
108
|
| 'if' construct must use '{}'s. |
115
|
| Line has trailing spaces. |
118
|
| 'if' construct must use '{}'s. |
121
|
| Line has trailing spaces. |
129
|
| Method 'updateMembers' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Missing a Javadoc comment. |
130
|
| Line has trailing spaces. |
133
|
| Line is longer than 80 characters. |
136
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Line has trailing spaces. |
141
|
| Line is longer than 80 characters. |
143
|
| Line is longer than 80 characters. |
144
|
| Line is longer than 80 characters. |
146
|
| Method 'setUrl' is not designed for extension - needs to be abstract, final or empty. |
148
|
| Parameter url should be final. |
148
|
| 'url' hides a field. |
148
|
| Line has trailing spaces. |
151
|
| Missing a Javadoc comment. |
152
|
| Line has trailing spaces. |
156
|
| Line is longer than 80 characters. |
156
|
| '+' should be on a new line. |
156
|
| '+' should be on a new line. |
157
|
| '+' should be on a new line. |
158
|
| Line has trailing spaces. |
159
|
| Line is longer than 80 characters. |
159
|
| '!=' is not preceded with whitespace. |
159
|
| '+' is not followed by whitespace. |
159
|
| Line is longer than 80 characters. |
160
|
| Line is longer than 80 characters. |
161
|
| Line is longer than 80 characters. |
169
|
| Line is longer than 80 characters. |
172
|
| '=' is not preceded with whitespace. |
177
|
| '=' is not followed by whitespace. |
177
|
| '<' is not preceded with whitespace. |
177
|
| Line is longer than 80 characters. |
182
|
| Line is longer than 80 characters. |
189
|
| Line has trailing spaces. |
192
|
| Missing a Javadoc comment. |
193
|
| Line has trailing spaces. |
194
|
| Line is longer than 80 characters. |
194
|
| '+' is not followed by whitespace. |
194
|
| '+' is not followed by whitespace. |
194
|
| '!=' is not preceded with whitespace. |
194
|
| '+' is not followed by whitespace. |
194
|
| Line has trailing spaces. |
208
|
| Method 'getPersistenceFactory' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Missing a Javadoc comment. |
209
|
| Line has trailing spaces. |
212
|
| Line is longer than 80 characters. |
213
|
| Method 'setPersistence' is not designed for extension - needs to be abstract, final or empty. |
213
|
| Missing a Javadoc comment. |
213
|
| Parameter persistanceFactory should be final. |
213
|
| 'persistanceFactory' hides a field. |
213
|
| Parameter name should be final. |
213
|
| 'name' hides a field. |
213
|
| Line has trailing spaces. |
217
|
| Line has trailing spaces. |
218
|
| Method 'getSslKey' is not designed for extension - needs to be abstract, final or empty. |
223
|
| Line has trailing spaces. |
226
|
| Line is longer than 80 characters. |
228
|
| Line is longer than 80 characters. |
229
|
| Method 'setSslKey' is not designed for extension - needs to be abstract, final or empty. |
231
|
| Parameter sslKey should be final. |
231
|
| 'sslKey' hides a field. |
231
|
| Line has trailing spaces. |
234
|
| Line is longer than 80 characters. |
236
|
| Line is longer than 80 characters. |
237
|
| Method 'getSslCertfile' is not designed for extension - needs to be abstract, final or empty. |
239
|
| Line has trailing spaces. |
242
|
| Line is longer than 80 characters. |
244
|
| Line is longer than 80 characters. |
245
|
| Method 'setSslCertfile' is not designed for extension - needs to be abstract, final or empty. |
247
|
| Parameter sslCertfile should be final. |
247
|
| 'sslCertfile' hides a field. |
247
|
| Line has trailing spaces. |
250
|
| Line is longer than 80 characters. |
252
|
| Line is longer than 80 characters. |
253
|
| Method 'getSslCAFiles' is not designed for extension - needs to be abstract, final or empty. |
255
|
| Line has trailing spaces. |
258
|
| Line is longer than 80 characters. |
260
|
| Line is longer than 80 characters. |
261
|
| Method 'setSslCAFiles' is not designed for extension - needs to be abstract, final or empty. |
263
|
| Parameter sslCAFiles should be final. |
263
|
| 'sslCAFiles' hides a field. |
263
|
| Line has trailing spaces. |
266
|
| Method 'getSslKeyPasswd' is not designed for extension - needs to be abstract, final or empty. |
271
|
| Line has trailing spaces. |
274
|
| Method 'setSslKeyPasswd' is not designed for extension - needs to be abstract, final or empty. |
279
|
| Parameter sslKeyPasswd should be final. |
279
|
| 'sslKeyPasswd' hides a field. |
279
|
| Line has trailing spaces. |
282
|
| Line has trailing spaces. |
283
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
284
|
| Missing a Javadoc comment. |
284
|
| Line is longer than 80 characters. |
285
|
| '+' is not preceded with whitespace. |
285
|
| '+' is not followed by whitespace. |
285
|
| '+' is not preceded with whitespace. |
285
|
| '+' is not followed by whitespace. |
285
|
| '+' is not followed by whitespace. |
285
|
| '+' is not followed by whitespace. |
285
|
| '!=' is not preceded with whitespace. |
285
|
| Avoid inline conditionals. |
285
|
| Line has trailing spaces. |
287
|
| Method 'getVoGroup' is not designed for extension - needs to be abstract, final or empty. |
292
|
| Line has trailing spaces. |
295
|
| Method 'setVoGroup' is not designed for extension - needs to be abstract, final or empty. |
300
|
| Parameter voGroup should be final. |
300
|
| 'voGroup' hides a field. |
300
|
| Line has trailing spaces. |
304
|
| Line is longer than 80 characters. |
307
|
| Method 'getVoRole' is not designed for extension - needs to be abstract, final or empty. |
309
|
| Line has trailing spaces. |
312
|
| Line is longer than 80 characters. |
315
|
| Method 'setVoRole' is not designed for extension - needs to be abstract, final or empty. |
317
|
| Parameter voRole should be final. |
317
|
| 'voRole' hides a field. |
317
|
| Line has trailing spaces. |
321
|
| Missing a Javadoc comment. |
322
|
| Line has trailing spaces. |
333
|
| Line is longer than 80 characters. |
335
|
| Line is longer than 80 characters. |
336
|
| Line is longer than 80 characters. |
337
|
| Line is longer than 80 characters. |
338
|
| Method 'isIgnoreFQAN' is not designed for extension - needs to be abstract, final or empty. |
344
|
| Line has trailing spaces. |
347
|
| Line is longer than 80 characters. |
350
|
| Method 'setIgnoreFQAN' is not designed for extension - needs to be abstract, final or empty. |
353
|
| Parameter ignoreFQAN should be final. |
353
|
| Line is longer than 80 characters. |
354
|
| Method 'getMatchFQAN' is not designed for extension - needs to be abstract, final or empty. |
378
|
| Line is longer than 80 characters. |
386
|
| Method 'setMatchFQAN' is not designed for extension - needs to be abstract, final or empty. |
388
|
| Parameter matchFQAN should be final. |
388
|
| 'matchFQAN' hides a field. |
388
|
| Line is longer than 80 characters. |
390
|
| Line is longer than 80 characters. |
402
|
| Line is longer than 80 characters. |
403
|
| Method 'isAcceptProxyWithoutFQAN' is not designed for extension - needs to be abstract, final or empty. |
406
|
| Method 'setAcceptProxyWithoutFQAN' is not designed for extension - needs to be abstract, final or empty. |
415
|
| Parameter acceptProxyWithoutFQAN should be final. |
415
|
| 'acceptProxyWithoutFQAN' hides a field. |
415
|
| Line has trailing spaces. |
419
|
gov/bnl/gums/WildcardHostGroup.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
9
|
| Using the '.*' form of import should be avoided - java.util.regex.*. |
10
|
| Line is longer than 80 characters. |
18
|
| Missing a Javadoc comment. |
24
|
| Variable 'adminLog' must be private and have accessor methods. |
24
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
28
|
| Line is longer than 80 characters. |
29
|
| Line is longer than 80 characters. |
31
|
| Line has trailing spaces. |
33
|
| Method 'isInGroup' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| Parameter hostname should be final. |
34
|
| 'if' construct must use '{}'s. |
37
|
| Line has trailing spaces. |
42
|
| Method 'getWildcard' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Line has trailing spaces. |
49
|
| Method 'setWildcard' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Parameter wildcard should be final. |
53
|
| 'wildcard' hides a field. |
53
|
| Line has trailing spaces. |
65
|
gov/bnl/gums/admin/AuthorizationDeniedException.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
14
|
| First sentence should end with a period. |
15
|
| Line has trailing spaces. |
19
|
gov/bnl/gums/admin/CertCache.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
20
|
| Line has trailing spaces. |
21
|
| First sentence should end with a period. |
22
|
| Line is longer than 80 characters. |
26
|
| Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| Parameter servletRequest should be final. |
26
|
| Parameter servletResponse should be final. |
26
|
| Parameter filterChain should be final. |
26
|
| Line is longer than 80 characters. |
28
|
| '{' is not preceded with whitespace. |
28
|
| Line is longer than 80 characters. |
29
|
| Line has trailing spaces. |
34
|
| Missing a Javadoc comment. |
35
|
| Line is longer than 80 characters. |
37
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Missing a Javadoc comment. |
37
|
| Parameter filterConfig should be final. |
37
|
| Missing a Javadoc comment. |
41
|
| Line has trailing spaces. |
43
|
| Missing a Javadoc comment. |
44
|
| Missing a Javadoc comment. |
45
|
| Line has trailing spaces. |
48
|
| Missing a Javadoc comment. |
49
|
| Parameter cert should be final. |
49
|
| Line has trailing spaces. |
52
|
| Line has trailing spaces. |
53
|
| Missing a Javadoc comment. |
54
|
| Line has trailing spaces. |
57
|
| Missing a Javadoc comment. |
58
|
| Line has trailing spaces. |
65
|
gov/bnl/gums/admin/CertToolkit.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Class CertToolkit should be declared as final. |
23
|
| Line has trailing spaces. |
24
|
| Missing a Javadoc comment. |
25
|
| Line has trailing spaces. |
27
|
| Missing a Javadoc comment. |
28
|
| Parameter cert should be final. |
28
|
| 'if' construct must use '{}'s. |
29
|
| Line has trailing spaces. |
46
|
| Missing a Javadoc comment. |
47
|
| Parameter commaDN should be final. |
47
|
| '+' is not preceded with whitespace. |
52
|
| '+' is not followed by whitespace. |
52
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
57
|
gov/bnl/gums/admin/GUMSAPI.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
11
|
| Line is longer than 80 characters. |
12
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Line is longer than 80 characters. |
26
|
| Missing a Javadoc comment. |
26
|
| Line is longer than 80 characters. |
27
|
| Missing a Javadoc comment. |
27
|
| Line is longer than 80 characters. |
28
|
| Missing a Javadoc comment. |
28
|
| Line is longer than 80 characters. |
29
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
gov/bnl/gums/admin/GUMSAPIImpl.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.*. |
9
|
| Missing a Javadoc comment. |
18
|
| Missing a Javadoc comment. |
19
|
| Missing a Javadoc comment. |
20
|
| Missing a Javadoc comment. |
21
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
23
|
| Line is longer than 80 characters. |
25
|
| Line has trailing spaces. |
29
|
| Method 'generateGrid3UserVoMap' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter hostname should be final. |
30
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
40
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
44
|
| Line has trailing spaces. |
48
|
| Method 'generateGridMapfile' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Parameter hostname should be final. |
49
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
53
|
| Line is longer than 80 characters. |
59
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
63
|
| Line has trailing spaces. |
67
|
| Line is longer than 80 characters. |
68
|
| Method 'manualGroupAdd' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Missing a Javadoc comment. |
68
|
| Parameter persistanceFactory should be final. |
68
|
| Parameter group should be final. |
68
|
| Parameter userDN should be final. |
68
|
| Line is longer than 80 characters. |
71
|
| Line is longer than 80 characters. |
74
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
83
|
| Line is longer than 80 characters. |
84
|
| Line has trailing spaces. |
88
|
| Line is longer than 80 characters. |
89
|
| Method 'manualGroupRemove' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Missing a Javadoc comment. |
89
|
| Parameter persistanceFactory should be final. |
89
|
| Parameter group should be final. |
89
|
| Parameter userDN should be final. |
89
|
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
95
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
102
|
| Line is longer than 80 characters. |
105
|
| Line is longer than 80 characters. |
106
|
| Line has trailing spaces. |
110
|
| Line is longer than 80 characters. |
111
|
| Method 'manualMappingAdd' is not designed for extension - needs to be abstract, final or empty. |
111
|
| Missing a Javadoc comment. |
111
|
| Parameter persistanceFactory should be final. |
111
|
| Parameter group should be final. |
111
|
| Parameter userDN should be final. |
111
|
| Parameter account should be final. |
111
|
| Line is longer than 80 characters. |
114
|
| Line is longer than 80 characters. |
115
|
| Line is longer than 80 characters. |
117
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
123
|
| Line is longer than 80 characters. |
124
|
| Line is longer than 80 characters. |
127
|
| Line is longer than 80 characters. |
128
|
| Line has trailing spaces. |
132
|
| Line is longer than 80 characters. |
133
|
| Method 'manualMappingRemove' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Missing a Javadoc comment. |
133
|
| Parameter persistanceFactory should be final. |
133
|
| Parameter group should be final. |
133
|
| Parameter userDN should be final. |
133
|
| Line is longer than 80 characters. |
136
|
| Line is longer than 80 characters. |
137
|
| Line is longer than 80 characters. |
139
|
| Line is longer than 80 characters. |
140
|
| Line is longer than 80 characters. |
145
|
| Line is longer than 80 characters. |
146
|
| Line is longer than 80 characters. |
149
|
| Line is longer than 80 characters. |
150
|
| Line has trailing spaces. |
154
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Missing a Javadoc comment. |
155
|
| Parameter hostname should be final. |
155
|
| Parameter userDN should be final. |
155
|
| Parameter fqan should be final. |
155
|
| Line is longer than 80 characters. |
157
|
| Line is longer than 80 characters. |
158
|
| Line is longer than 80 characters. |
159
|
| Line is longer than 80 characters. |
165
|
| Line is longer than 80 characters. |
166
|
| Line is longer than 80 characters. |
169
|
| Line has trailing spaces. |
173
|
| Method 'mapfileCacheRefresh' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Missing a Javadoc comment. |
174
|
| Line is longer than 80 characters. |
177
|
| Line is longer than 80 characters. |
182
|
| Line is longer than 80 characters. |
183
|
| Line is longer than 80 characters. |
186
|
| Line has trailing spaces. |
190
|
| Method 'updateGroups' is not designed for extension - needs to be abstract, final or empty. |
191
|
| Missing a Javadoc comment. |
191
|
| Line is longer than 80 characters. |
201
|
| Line is longer than 80 characters. |
202
|
| Line is longer than 80 characters. |
205
|
| Line is longer than 80 characters. |
206
|
| Line is longer than 80 characters. |
211
|
| Method 'poolAddAccount' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Missing a Javadoc comment. |
211
|
| Parameter persistanceFactory should be final. |
211
|
| Parameter group should be final. |
211
|
| Parameter username should be final. |
211
|
| Line is longer than 80 characters. |
214
|
| Line is longer than 80 characters. |
216
|
| Line is longer than 80 characters. |
218
|
| Line is longer than 80 characters. |
220
|
| Line is longer than 80 characters. |
221
|
| Line is longer than 80 characters. |
226
|
| Line is longer than 80 characters. |
227
|
| Line is longer than 80 characters. |
230
|
| Line is longer than 80 characters. |
231
|
| Line has trailing spaces. |
235
|
| Method 'logUserAccess' is not designed for extension - needs to be abstract, final or empty. |
236
|
| Missing a Javadoc comment. |
236
|
| Line has trailing spaces. |
243
|
| Missing a Javadoc comment. |
244
|
| Line has trailing spaces. |
253
|
| Method 'currentUser' is not designed for extension - needs to be abstract, final or empty. |
254
|
| Missing a Javadoc comment. |
254
|
| 'if' construct must use '{}'s. |
255
|
| Name 'DN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
256
|
| Line has trailing spaces. |
263
|
| Method 'isHostAuthZ' is not designed for extension - needs to be abstract, final or empty. |
264
|
| Missing a Javadoc comment. |
264
|
| Parameter user should be final. |
264
|
| Parameter hostname should be final. |
264
|
| 'if' construct must use '{}'s. |
265
|
| 'if' construct must use '{}'s. |
266
|
| Line has trailing spaces. |
269
|
| Method 'isAdmin' is not designed for extension - needs to be abstract, final or empty. |
270
|
| Missing a Javadoc comment. |
270
|
| Parameter user should be final. |
270
|
| 'if' construct must use '{}'s. |
271
|
| 'if' construct must use '{}'s. |
272
|
| 'if' construct must use '{}'s. |
273
|
gov/bnl/gums/admin/GUMSAPIMock.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Method 'generateGridMapfile' is not designed for extension - needs to be abstract, final or empty. |
14
|
| Missing a Javadoc comment. |
14
|
| Parameter hostname should be final. |
14
|
| Method 'generateGrid3UserVoMap' is not designed for extension - needs to be abstract, final or empty. |
18
|
| Missing a Javadoc comment. |
18
|
| Parameter hostname should be final. |
18
|
| Missing a Javadoc comment. |
22
|
| Line is longer than 80 characters. |
25
|
| Missing a Javadoc comment. |
25
|
| Parameter persistanceFactory should be final. |
25
|
| Parameter group should be final. |
25
|
| Parameter username should be final. |
25
|
| Missing a Javadoc comment. |
28
|
| Method 'mapUser' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter hostname should be final. |
31
|
| Parameter userDN should be final. |
31
|
| Parameter fqan should be final. |
31
|
| Line is longer than 80 characters. |
35
|
| Missing a Javadoc comment. |
35
|
| Parameter persistanceFactory should be final. |
35
|
| Parameter group should be final. |
35
|
| Parameter userDN should be final. |
35
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter persistanceFactory should be final. |
38
|
| Parameter group should be final. |
38
|
| Parameter userDN should be final. |
38
|
| Parameter account should be final. |
38
|
| Line is longer than 80 characters. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter persistanceFactory should be final. |
41
|
| Parameter group should be final. |
41
|
| Parameter userDN should be final. |
41
|
| Line is longer than 80 characters. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter persistanceFactory should be final. |
44
|
| Parameter group should be final. |
44
|
| Parameter userDN should be final. |
44
|
| Line has trailing spaces. |
46
|
gov/bnl/gums/command/AbstractCommand.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - org.apache.commons.cli.*. |
13
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.admin.*. |
19
|
| Missing a Javadoc comment. |
27
|
| Variable 'command' must be private and have accessor methods. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Variable 'commandName' must be private and have accessor methods. |
29
|
| Missing a Javadoc comment. |
30
|
| Variable 'syntax' must be private and have accessor methods. |
30
|
| Missing a Javadoc comment. |
31
|
| Variable 'description' must be private and have accessor methods. |
31
|
| Missing a Javadoc comment. |
32
|
| Variable 'failOnArguments' must be private and have accessor methods. |
32
|
| Line has trailing spaces. |
42
|
| Missing a Javadoc comment. |
43
|
| Missing a Javadoc comment. |
44
|
| Missing a Javadoc comment. |
45
|
| 'if' construct must use '{}'s. |
47
|
| Line has trailing spaces. |
48
|
| Line has trailing spaces. |
50
|
| Line has trailing spaces. |
55
|
| Line has trailing spaces. |
60
|
| Line has trailing spaces. |
62
|
| Line has trailing spaces. |
82
|
| Method 'getClientDN' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Missing a Javadoc comment. |
83
|
| Line has trailing spaces. |
87
|
| Method 'isUsingProxy' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Missing a Javadoc comment. |
93
|
| Method 'parse' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Missing a Javadoc comment. |
95
|
| Parameter options should be final. |
95
|
| Parameter args should be final. |
95
|
| '&&' should be on a new line. |
107
|
| Method 'printHelp' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Missing a Javadoc comment. |
128
|
| Parameter options should be final. |
128
|
| Method 'failForWrongParameters' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Missing a Javadoc comment. |
135
|
| Parameter message should be final. |
135
|
| '+' should be on a new line. |
137
|
| Missing a Javadoc comment. |
142
|
| Parameter cmd should be final. |
142
|
| Missing a Javadoc comment. |
144
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Missing a Javadoc comment. |
146
|
| Parameter args should be final. |
146
|
| '+' should be on a new line. |
165
|
| Line is longer than 80 characters. |
166
|
| '+' should be on a new line. |
166
|
| Line is longer than 80 characters. |
167
|
| '+' should be on a new line. |
169
|
| Line is longer than 80 characters. |
171
|
| Line is longer than 80 characters. |
172
|
| '+' should be on a new line. |
174
|
| Line has trailing spaces. |
176
|
| Line is longer than 80 characters. |
176
|
| '&&' should be on a new line. |
176
|
| Line is longer than 80 characters. |
177
|
| '&&' should be on a new line. |
177
|
| Line is longer than 80 characters. |
178
|
| Line is longer than 80 characters. |
179
|
| '+' should be on a new line. |
181
|
| Line is longer than 80 characters. |
183
|
| '&&' should be on a new line. |
183
|
| Line is longer than 80 characters. |
184
|
| '&&' should be on a new line. |
184
|
| Line is longer than 80 characters. |
185
|
| Line is longer than 80 characters. |
186
|
| '+' should be on a new line. |
188
|
| '+' should be on a new line. |
192
|
| Line has trailing spaces. |
195
|
| Line is longer than 80 characters. |
198
|
| Line is longer than 80 characters. |
199
|
| '+' should be on a new line. |
201
|
| '+' should be on a new line. |
205
|
| Line is longer than 80 characters. |
213
|
| First sentence should end with a period. |
221
|
| Comment matches to-do format 'TODO:'. |
222
|
| Comment matches to-do format 'TODO:'. |
224
|
| Parameter args should be final. |
226
|
gov/bnl/gums/command/CommandLineToolkit.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.admin.*. |
8
|
| Class CommandLineToolkit should be declared as final. |
13
|
| First sentence should end with a period. |
14
|
| First sentence should end with a period. |
20
|
| Comment matches to-do format 'TODO:'. |
21
|
| Comment matches to-do format 'TODO:'. |
23
|
| Comment matches to-do format 'TODO:'. |
25
|
| Parameter className should be final. |
27
|
gov/bnl/gums/command/Configuration.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.admin.*. |
14
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| First sentence should end with a period. |
30
|
| Comment matches to-do format 'TODO:'. |
31
|
| Comment matches to-do format 'TODO:'. |
33
|
| Missing a Javadoc comment. |
39
|
| Line is longer than 80 characters. |
40
|
| Line is longer than 80 characters. |
52
|
| Line has trailing spaces. |
54
|
| Line has trailing spaces. |
60
|
| Line has trailing spaces. |
68
|
| '+' should be on a new line. |
73
|
| Line has trailing spaces. |
76
|
| '+' should be on a new line. |
82
|
| Line has trailing spaces. |
86
|
| Method 'isDirect' is not designed for extension - needs to be abstract, final or empty. |
87
|
| Missing a Javadoc comment. |
87
|
| First sentence should end with a period. |
95
|
| Comment matches to-do format 'TODO:'. |
96
|
| Comment matches to-do format 'TODO:'. |
98
|
| Method 'getGUMSLocation' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Method 'getGUMSAuthZLocation' is not designed for extension - needs to be abstract, final or empty. |
108
|
| Missing a Javadoc comment. |
108
|
gov/bnl/gums/command/GUMSCommandLine.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.admin.*. |
19
|
| Utility classes should not have a public or default constructor. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Missing a Javadoc comment. |
28
|
| Missing a Javadoc comment. |
29
|
| Variable 'command' must be private and have accessor methods. |
29
|
| Missing a Javadoc comment. |
31
|
| Parameter className should be final. |
31
|
| Parameter description should be final. |
31
|
| 'command' hides a field. |
32
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
42
|
| 'command' hides a field. |
49
|
| '+' should be on a new line. |
51
|
| Parameter args should be final. |
62
|
| 'command' hides a field. |
68
|
| Missing a Javadoc comment. |
85
|
| Parameter command should be final. |
85
|
| 'command' hides a field. |
85
|
| Parameter args should be final. |
85
|
| '{' is followed by whitespace. |
98
|
| '{' is followed by whitespace. |
100
|
| '+' should be on a new line. |
104
|
| '+' should be on a new line. |
109
|
| '+' should be on a new line. |
115
|
| Line is longer than 80 characters. |
121
|
| '+' should be on a new line. |
121
|
| '+' should be on a new line. |
126
|
| Line is longer than 80 characters. |
128
|
gov/bnl/gums/hibernate/HibernateMapping.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.util.*. |
15
|
| Unused import - javax.naming.OperationNotSupportedException. |
16
|
| Using the '.*' form of import should be avoided - net.sf.hibernate.*. |
17
|
| Line is longer than 80 characters. |
27
|
| Missing a Javadoc comment. |
28
|
| Line has trailing spaces. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Line has trailing spaces. |
32
|
| First sentence should end with a period. |
33
|
| Parameter factory should be final. |
34
|
| 'factory' hides a field. |
34
|
| Expected @param tag for 'factory'. |
34
|
| Parameter map should be final. |
34
|
| 'map' hides a field. |
34
|
| Expected @param tag for 'map'. |
34
|
| Method 'retrieveMapping' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter userDN should be final. |
39
|
| Line is longer than 80 characters. |
43
|
| 'map' hides a field. |
46
|
| 'if' construct must use '{}'s. |
48
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
68
|
| Line has trailing spaces. |
73
|
| Line is longer than 80 characters. |
74
|
| Missing a Javadoc comment. |
74
|
| Parameter session should be final. |
74
|
| Parameter tx should be final. |
74
|
| Parameter userDN should be final. |
74
|
| '{' is not preceded with whitespace. |
74
|
| Method 'removeMapping' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Missing a Javadoc comment. |
82
|
| Parameter userDN should be final. |
82
|
| Line is longer than 80 characters. |
86
|
| Line is longer than 80 characters. |
94
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
110
|
| Line has trailing spaces. |
115
|
| Line is longer than 80 characters. |
116
|
| Missing a Javadoc comment. |
116
|
| Parameter session should be final. |
116
|
| Parameter tx should be final. |
116
|
| Parameter userDN should be final. |
116
|
| Line is longer than 80 characters. |
117
|
| Method 'createMapping' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Missing a Javadoc comment. |
121
|
| Parameter userDN should be final. |
121
|
| Parameter account should be final. |
121
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
142
|
| Line is longer than 80 characters. |
152
|
| Line has trailing spaces. |
157
|
| Line is longer than 80 characters. |
158
|
| Missing a Javadoc comment. |
158
|
| Parameter session should be final. |
158
|
| Parameter tx should be final. |
158
|
| Parameter userDN should be final. |
158
|
| Parameter account should be final. |
158
|
| Method 'addAccount' is not designed for extension - needs to be abstract, final or empty. |
166
|
| Missing a Javadoc comment. |
166
|
| Parameter account should be final. |
166
|
| Line is longer than 80 characters. |
187
|
| Line is longer than 80 characters. |
197
|
| Method 'assignAccount' is not designed for extension - needs to be abstract, final or empty. |
203
|
| Missing a Javadoc comment. |
203
|
| Parameter userDN should be final. |
203
|
| Line is longer than 80 characters. |
207
|
| Line is longer than 80 characters. |
211
|
| Line is longer than 80 characters. |
223
|
| Line is longer than 80 characters. |
229
|
| Line is longer than 80 characters. |
239
|
| Method 'unassignUser' is not designed for extension - needs to be abstract, final or empty. |
245
|
| Missing a Javadoc comment. |
245
|
| Parameter userDN should be final. |
245
|
| Line is longer than 80 characters. |
249
|
| Line is longer than 80 characters. |
253
|
| Line is longer than 80 characters. |
264
|
| Line is longer than 80 characters. |
270
|
| Line is longer than 80 characters. |
280
|
| Method 'retrieveAccount' is not designed for extension - needs to be abstract, final or empty. |
286
|
| Missing a Javadoc comment. |
286
|
| Parameter userDN should be final. |
286
|
| Line is longer than 80 characters. |
290
|
| Line is longer than 80 characters. |
294
|
| 'if' construct must use '{}'s. |
299
|
| Line is longer than 80 characters. |
303
|
| Line is longer than 80 characters. |
309
|
| Line is longer than 80 characters. |
319
|
| Method 'retrieveUsersNotUsedSince' is not designed for extension - needs to be abstract, final or empty. |
325
|
| Missing a Javadoc comment. |
325
|
| Parameter date should be final. |
325
|
| Line is longer than 80 characters. |
326
|
| Method 'retrieveAccountMap' is not designed for extension - needs to be abstract, final or empty. |
329
|
| Missing a Javadoc comment. |
329
|
| Line is longer than 80 characters. |
337
|
| 'map' hides a field. |
341
|
| Line is longer than 80 characters. |
356
|
| Line is longer than 80 characters. |
366
|
| Line has trailing spaces. |
371
|
gov/bnl/gums/hibernate/HibernatePersistenceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - net.sf.hibernate.*. |
18
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.*. |
21
|
| Missing a Javadoc comment. |
28
|
| Line has trailing spaces. |
29
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Line has trailing spaces. |
33
|
| Missing a Javadoc comment. |
34
|
| Method 'retrieveUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter name should be final. |
38
|
| 'name' hides a field. |
38
|
| Method 'retrieveManualUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter name should be final. |
42
|
| 'name' hides a field. |
42
|
| Method 'retrieveManualAccountMapperDB' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter name should be final. |
46
|
| 'name' hides a field. |
46
|
| Method 'retrieveAccountPoolMapperDB' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter name should be final. |
50
|
| 'name' hides a field. |
50
|
| Line has trailing spaces. |
53
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Line has trailing spaces. |
57
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
| Parameter name should be final. |
58
|
| 'name' hides a field. |
58
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Missing a Javadoc comment. |
62
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Missing a Javadoc comment. |
66
|
| Parameter properties should be final. |
66
|
| 'properties' hides a field. |
66
|
| Line has trailing spaces. |
69
|
| Method 'setConnectionFromHibernateProperties' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Missing a Javadoc comment. |
70
|
| Line is longer than 80 characters. |
74
|
| Line has trailing spaces. |
77
|
| Missing a Javadoc comment. |
78
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line has trailing spaces. |
89
|
| Method 'retrieveSessionFactory' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Missing a Javadoc comment. |
90
|
| 'if' construct must use '{}'s. |
91
|
| Line has trailing spaces. |
95
|
| Missing a Javadoc comment. |
96
|
| Line is longer than 80 characters. |
98
|
| Line is longer than 80 characters. |
99
|
| Line is longer than 80 characters. |
100
|
| Line is longer than 80 characters. |
101
|
| Line is longer than 80 characters. |
108
|
| '+' is not preceded with whitespace. |
108
|
| Line has trailing spaces. |
111
|
gov/bnl/gums/hibernate/HibernateUserGroupDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.*. |
13
|
| Using the '.*' form of import should be avoided - net.sf.hibernate.*. |
19
|
| Using the '.*' form of import should be avoided - org.apache.commons.logging.*. |
22
|
| Missing a Javadoc comment. |
29
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
32
|
| Line has trailing spaces. |
33
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Line has trailing spaces. |
36
|
| First sentence should end with a period. |
37
|
| Line is longer than 80 characters. |
38
|
| Parameter factory should be final. |
38
|
| 'factory' hides a field. |
38
|
| Expected @param tag for 'factory'. |
38
|
| Parameter group should be final. |
38
|
| 'group' hides a field. |
38
|
| Expected @param tag for 'group'. |
38
|
| Method 'isMemberInGroup' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter user should be final. |
44
|
| Line is longer than 80 characters. |
48
|
| Line is longer than 80 characters. |
57
|
| Line is longer than 80 characters. |
63
|
| Line is longer than 80 characters. |
73
|
| Line has trailing spaces. |
78
|
| Line is longer than 80 characters. |
79
|
| Missing a Javadoc comment. |
79
|
| Parameter session should be final. |
79
|
| Parameter tx should be final. |
79
|
| Parameter user should be final. |
79
|
| Line is longer than 80 characters. |
82
|
| Line is longer than 80 characters. |
84
|
| Method 'loadUpdatedList' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Parameter members should be final. |
93
|
| Line is longer than 80 characters. |
99
|
| Line has trailing spaces. |
107
|
| Line has trailing spaces. |
110
|
| Line has trailing spaces. |
116
|
| Line is longer than 80 characters. |
119
|
| Line has trailing spaces. |
126
|
| Line is longer than 80 characters. |
129
|
| Line has trailing spaces. |
136
|
| Line has trailing spaces. |
138
|
| Line is longer than 80 characters. |
149
|
| Line has trailing spaces. |
152
|
| '&&' should be on a new line. |
152
|
| Line has trailing spaces. |
153
|
| '&&' should be on a new line. |
153
|
| '&&' should be on a new line. |
154
|
| Line is longer than 80 characters. |
156
|
| Line is longer than 80 characters. |
168
|
| Method 'retrieveRemovedMembers' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Missing a Javadoc comment. |
174
|
| Method 'retrieveNewMembers' is not designed for extension - needs to be abstract, final or empty. |
178
|
| Missing a Javadoc comment. |
178
|
| Method 'retrieveMembers' is not designed for extension - needs to be abstract, final or empty. |
182
|
| Missing a Javadoc comment. |
182
|
| Line is longer than 80 characters. |
195
|
| Line is longer than 80 characters. |
201
|
| Line is longer than 80 characters. |
211
|
| Line has trailing spaces. |
216
|
| Line is longer than 80 characters. |
217
|
| Missing a Javadoc comment. |
217
|
| Parameter session should be final. |
217
|
| Parameter tx should be final. |
217
|
| Line has trailing spaces. |
230
|
| Line is longer than 80 characters. |
231
|
| Missing a Javadoc comment. |
231
|
| Parameter session should be final. |
231
|
| Parameter tx should be final. |
231
|
| Parameter user should be final. |
231
|
| Line is longer than 80 characters. |
233
|
| Line is longer than 80 characters. |
236
|
| Line has trailing spaces. |
240
|
| Line is longer than 80 characters. |
241
|
| Missing a Javadoc comment. |
241
|
| Parameter session should be final. |
241
|
| Parameter tx should be final. |
241
|
| Parameter user should be final. |
241
|
| Method 'addMember' is not designed for extension - needs to be abstract, final or empty. |
251
|
| Missing a Javadoc comment. |
251
|
| Parameter user should be final. |
251
|
| Line is longer than 80 characters. |
259
|
| Line is longer than 80 characters. |
271
|
| Line is longer than 80 characters. |
281
|
| Method 'removeMember' is not designed for extension - needs to be abstract, final or empty. |
287
|
| Missing a Javadoc comment. |
287
|
| Parameter user should be final. |
287
|
| Line is longer than 80 characters. |
305
|
| Line is longer than 80 characters. |
315
|
gov/bnl/gums/hibernate/Mapping.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.util.Date. |
13
|
| Line has trailing spaces. |
20
|
| First sentence should end with a period. |
21
|
| Line has trailing spaces. |
22
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Parameter id should be final. |
45
|
| 'id' hides a field. |
45
|
| Method 'getDn' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Method 'setDn' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Parameter dn should be final. |
68
|
| 'dn' hides a field. |
68
|
| Method 'getAccount' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Method 'setAccount' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter account should be final. |
91
|
| 'account' hides a field. |
91
|
| Method 'getMap' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Unused @param tag for 'userGroup'. |
112
|
| Method 'setMap' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter map should be final. |
114
|
| 'map' hides a field. |
114
|
| Expected @param tag for 'map'. |
114
|
| Line has trailing spaces. |
119
|
gov/bnl/gums/hibernate/User.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.util.Date. |
13
|
| Line has trailing spaces. |
20
|
| First sentence should end with a period. |
21
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Parameter id should be final. |
43
|
| 'id' hides a field. |
43
|
| Method 'getDn' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Method 'setDn' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Parameter dn should be final. |
66
|
| 'dn' hides a field. |
66
|
| Method 'getFqan' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Method 'setFqan' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Parameter fqan should be final. |
89
|
| 'fqan' hides a field. |
89
|
| Method 'getGroup' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Method 'setGroup' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Parameter group should be final. |
112
|
| 'group' hides a field. |
112
|
| Line has trailing spaces. |
116
|
gov/bnl/gums/hibernate/package.html
Error | Line |
| Missing package documentation file. | 0 |
gov/bnl/gums/ldap/LDAPGroupIDAssigner.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
23
|
| Missing a Javadoc comment. |
24
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
27
|
| Line has trailing spaces. |
28
|
| Line is longer than 80 characters. |
30
|
| Parameter factory should be final. |
36
|
| 'factory' hides a field. |
36
|
| Parameter domains should be final. |
36
|
| 'domains' hides a field. |
36
|
| Line is longer than 80 characters. |
39
|
| Line has trailing spaces. |
41
|
| Line is longer than 80 characters. |
43
|
| Line is longer than 80 characters. |
46
|
| Method 'assignGroups' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Parameter username should be final. |
48
|
| Parameter primary should be final. |
48
|
| Parameter secondary should be final. |
48
|
| Line is longer than 80 characters. |
50
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
68
|
| Method 'reassignGroups' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Parameter username should be final. |
68
|
| Parameter primary should be final. |
68
|
| Parameter secondary should be final. |
68
|
| Line is longer than 80 characters. |
72
|
| Line has trailing spaces. |
75
|
| Line is longer than 80 characters. |
81
|
| Line is longer than 80 characters. |
83
|
| Method 'assignGroups' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter domain should be final. |
83
|
| Parameter username should be final. |
83
|
| Parameter primary should be final. |
83
|
| Parameter secondary should be final. |
83
|
| Line is longer than 80 characters. |
86
|
| 'if' construct must use '{}'s. |
87
|
| Line is longer than 80 characters. |
92
|
| Line is longer than 80 characters. |
95
|
| Line is longer than 80 characters. |
96
|
| Line is longer than 80 characters. |
97
|
| Line has trailing spaces. |
100
|
gov/bnl/gums/ldap/LDAPMapDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.naming.directory.*. |
20
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Line has trailing spaces. |
39
|
| Parameter factory should be final. |
45
|
| 'factory' hides a field. |
45
|
| Parameter map should be final. |
45
|
| 'map' hides a field. |
45
|
| Line is longer than 80 characters. |
50
|
| Line is longer than 80 characters. |
61
|
| Line is longer than 80 characters. |
63
|
| Parameter factory should be final. |
63
|
| 'factory' hides a field. |
63
|
| Parameter map should be final. |
63
|
| 'map' hides a field. |
63
|
| Parameter group should be final. |
63
|
| 'group' hides a field. |
63
|
| Parameter secondaryGroups should be final. |
63
|
| 'secondaryGroups' hides a field. |
63
|
| Line is longer than 80 characters. |
67
|
| Line has trailing spaces. |
69
|
| Method 'doesMapExist' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Line is longer than 80 characters. |
80
|
| Line is longer than 80 characters. |
84
|
| Line has trailing spaces. |
89
|
| Method 'createGroupIfNotExists' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Line is longer than 80 characters. |
96
|
| Method 'retrieveMapping' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Parameter userDN should be final. |
105
|
| Line is longer than 80 characters. |
110
|
| 'map' hides a field. |
114
|
| 'if' construct must use '{}'s. |
115
|
| Line is longer than 80 characters. |
118
|
| Line is longer than 80 characters. |
123
|
| Line is longer than 80 characters. |
124
|
| Method 'removeMapping' is not designed for extension - needs to be abstract, final or empty. |
135
|
| Parameter userDN should be final. |
135
|
| 'if' construct must use '{}'s. |
139
|
| Line is longer than 80 characters. |
146
|
| Method 'unassignUser' is not designed for extension - needs to be abstract, final or empty. |
150
|
| Parameter userDN should be final. |
150
|
| Method 'retrieveAccount' is not designed for extension - needs to be abstract, final or empty. |
159
|
| Parameter userDN should be final. |
159
|
| Line is longer than 80 characters. |
161
|
| Line is longer than 80 characters. |
163
|
| Line is longer than 80 characters. |
164
|
| Line is longer than 80 characters. |
170
|
| Method 'assignAccount' is not designed for extension - needs to be abstract, final or empty. |
174
|
| Parameter userDN should be final. |
174
|
| Line is longer than 80 characters. |
181
|
| '100' is a magic number. |
181
|
| Line is longer than 80 characters. |
184
|
| Line is longer than 80 characters. |
201
|
| Line is longer than 80 characters. |
202
|
| Line is longer than 80 characters. |
215
|
| Line is longer than 80 characters. |
216
|
| Line is longer than 80 characters. |
217
|
| Line is longer than 80 characters. |
219
|
| Method 'addAccount' is not designed for extension - needs to be abstract, final or empty. |
228
|
| Parameter account should be final. |
228
|
| Line is longer than 80 characters. |
233
|
| First sentence should end with a period. |
238
|
| Method 'retrieveUsersNotUsedSince' is not designed for extension - needs to be abstract, final or empty. |
244
|
| Parameter date should be final. |
244
|
| Line is longer than 80 characters. |
245
|
| Line is longer than 80 characters. |
249
|
| Method 'createMapping' is not designed for extension - needs to be abstract, final or empty. |
253
|
| Parameter userDN should be final. |
253
|
| Parameter account should be final. |
253
|
| Line is longer than 80 characters. |
260
|
| Method 'retrieveAccountMap' is not designed for extension - needs to be abstract, final or empty. |
262
|
| 'map' hides a field. |
264
|
| Line is longer than 80 characters. |
268
|
| Line is longer than 80 characters. |
284
|
| Line has trailing spaces. |
289
|
| Method 'resetAccountPool' is not designed for extension - needs to be abstract, final or empty. |
290
|
| Missing a Javadoc comment. |
290
|
| Line is longer than 80 characters. |
295
|
| Line is longer than 80 characters. |
307
|
| Line is longer than 80 characters. |
313
|
| Line has trailing spaces. |
318
|
gov/bnl/gums/ldap/LDAPPersistenceFactory.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - javax.naming.Name. |
19
|
| Unused import - javax.naming.directory.InitialDirContext. |
28
|
| Using the '.*' form of import should be avoided - gov.bnl.gums.*. |
35
|
| Line has trailing spaces. |
42
|
| Missing a Javadoc comment. |
43
|
| Missing a Javadoc comment. |
44
|
| Line has trailing spaces. |
45
|
| Missing a Javadoc comment. |
46
|
| Missing a Javadoc comment. |
47
|
| Missing a Javadoc comment. |
48
|
| Missing a Javadoc comment. |
49
|
| Missing a Javadoc comment. |
50
|
| Missing a Javadoc comment. |
51
|
| Line has trailing spaces. |
53
|
| Missing a Javadoc comment. |
55
|
| Line has trailing spaces. |
56
|
| Line has trailing spaces. |
58
|
| Method 'createLDAPContext' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Line is longer than 80 characters. |
65
|
| Line is longer than 80 characters. |
66
|
| Line has trailing spaces. |
69
|
| Line is longer than 80 characters. |
70
|
| Line has trailing spaces. |
72
|
| Method 'retrieveContext' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Line has trailing spaces. |
88
|
| Missing a Javadoc comment. |
89
|
| Line has trailing spaces. |
90
|
| Line has trailing spaces. |
92
|
| Method 'releaseContext' is not designed for extension - needs to be abstract, final or empty. |
95
|
| Parameter context should be final. |
95
|
| Line has trailing spaces. |
103
|
| Missing a Javadoc comment. |
104
|
| Parameter context should be final. |
104
|
| Line is longer than 80 characters. |
110
|
| Line has trailing spaces. |
114
|
| Line has trailing spaces. |
118
|
| Method 'getLDAPContext' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Line has trailing spaces. |
124
|
| Line has trailing spaces. |
126
|
| Method 'retrieveUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Missing a Javadoc comment. |
127
|
| Parameter name should be final. |
127
|
| 'name' hides a field. |
127
|
| Method 'retrieveManualUserGroupDB' is not designed for extension - needs to be abstract, final or empty. |
132
|
| Missing a Javadoc comment. |
132
|
| Parameter name should be final. |
132
|
| 'name' hides a field. |
132
|
| Method 'retrieveManualAccountMapperDB' is not designed for extension - needs to be abstract, final or empty. |
137
|
| Missing a Javadoc comment. |
137
|
| Parameter name should be final. |
137
|
| 'name' hides a field. |
137
|
| Method 'retrieveAccountPoolMapperDB' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Missing a Javadoc comment. |
142
|
| Parameter name should be final. |
142
|
| 'name' hides a field. |
142
|
| Line is longer than 80 characters. |
145
|
| Line has trailing spaces. |
148
|
| Line is longer than 80 characters. |
151
|
| Line has trailing spaces. |
154
|
| Line has trailing spaces. |
160
|
| Line is longer than 80 characters. |
161
|
| Line has trailing spaces. |
164
|
| Missing a Javadoc comment. |
166
|
| Variable 'assigner' must be private and have accessor methods. |
166
|
| Line has trailing spaces. |
169
|
| Method 'retrieveAssigner' is not designed for extension - needs to be abstract, final or empty. |
172
|
| Line has trailing spaces. |
181
|
| Line has trailing spaces. |
183
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
186
|
| Line has trailing spaces. |
189
|
| Line has trailing spaces. |
191
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
194
|
| Parameter name should be final. |
194
|
| 'name' hides a field. |
194
|
| Method 'getDefaultGumsOU' is not designed for extension - needs to be abstract, final or empty. |
204
|
| Unused @param tag for 'baseDN'. |
213
|
| Method 'setDefaultGumsOU' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Parameter defaultGumsOU should be final. |
215
|
| 'defaultGumsOU' hides a field. |
215
|
| Expected @param tag for 'defaultGumsOU'. |
215
|
| Line has trailing spaces. |
221
|
| Method 'getUpdateGIDdomains' is not designed for extension - needs to be abstract, final or empty. |
229
|
| Line has trailing spaces. |
234
|
| Method 'setUpdateGIDdomains' is not designed for extension - needs to be abstract, final or empty. |
242
|
| Parameter updateGIDdomains should be final. |
242
|
| 'updateGIDdomains' hides a field. |
242
|
| Line is longer than 80 characters. |
250
|
| Method 'isSynchGroups' is not designed for extension - needs to be abstract, final or empty. |
252
|
| Line is longer than 80 characters. |
259
|
| Method 'setSynchGroups' is not designed for extension - needs to be abstract, final or empty. |
261
|
| Parameter synchGroups should be final. |
261
|
| 'synchGroups' hides a field. |
261
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
270
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
279
|
| Parameter properties should be final. |
279
|
| 'properties' hides a field. |
279
|
| Line is longer than 80 characters. |
281
|
| Method 'setConnectionFromLdapProperties' is not designed for extension - needs to be abstract, final or empty. |
291
|
| Line is longer than 80 characters. |
295
|
| Line has trailing spaces. |
298
|
| Missing a Javadoc comment. |
299
|
| Line is longer than 80 characters. |
300
|
| Line is longer than 80 characters. |
301
|
| Line has trailing spaces. |
310
|
| Line has trailing spaces. |
311
|
| Line has trailing spaces. |
312
|
| Line has trailing spaces. |
314
|
| Method 'createMap' is not designed for extension - needs to be abstract, final or empty. |
318
|
| Parameter mapName should be final. |
318
|
| Parameter mapDN should be final. |
318
|
| Line is longer than 80 characters. |
331
|
| Line is longer than 80 characters. |
332
|
| Line has trailing spaces. |
337
|
| Line has trailing spaces. |
340
|
| Method 'destroyMap' is not designed for extension - needs to be abstract, final or empty. |
344
|
| Parameter mapName should be final. |
344
|
| Parameter mapDN should be final. |
344
|
| Line is longer than 80 characters. |
349
|
| 'if' construct must use '{}'s. |
352
|
| Line is longer than 80 characters. |
356
|
| Line is longer than 80 characters. |
358
|
| Line is longer than 80 characters. |
359
|
| Line has trailing spaces. |
364
|
| Line has trailing spaces. |
366
|
| Line is longer than 80 characters. |
367
|
| Line is longer than 80 characters. |
372
|
| Method 'addMapEntry' is not designed for extension - needs to be abstract, final or empty. |
372
|
| Parameter userDN should be final. |
372
|
| Parameter account should be final. |
372
|
| Parameter mapName should be final. |
372
|
| Parameter mapDN should be final. |
372
|
| Line is longer than 80 characters. |
379
|
| Line is longer than 80 characters. |
380
|
| Line is longer than 80 characters. |
391
|
| Line is longer than 80 characters. |
392
|
| Line is longer than 80 characters. |
395
|
| Line is longer than 80 characters. |
396
|
| Line has trailing spaces. |
401
|
| Line is longer than 80 characters. |
402
|
| Line has trailing spaces. |
404
|
| Method 'createAccountInMap' is not designed for extension - needs to be abstract, final or empty. |
409
|
| Parameter account should be final. |
409
|
| Parameter mapName should be final. |
409
|
| Parameter mapDN should be final. |
409
|
| Line is longer than 80 characters. |
420
|
| Line is longer than 80 characters. |
422
|
| Line is longer than 80 characters. |
423
|
| Line has trailing spaces. |
428
|
| Line has trailing spaces. |
431
|
| Line is longer than 80 characters. |
432
|
| Method 'removeMapEntry' is not designed for extension - needs to be abstract, final or empty. |
437
|
| Parameter userDN should be final. |
437
|
| Parameter mapName should be final. |
437
|
| Parameter mapDN should be final. |
437
|
| Line is longer than 80 characters. |
443
|
| 'if' construct must use '{}'s. |
446
|
| Line is longer than 80 characters. |
452
|
| Line is longer than 80 characters. |
456
|
| Line is longer than 80 characters. |
457
|
| Line has trailing spaces. |
464
|
| Line has trailing spaces. |
466
|
| Method 'createUserGroup' is not designed for extension - needs to be abstract, final or empty. |
470
|
| Parameter groupName should be final. |
470
|
| Parameter groupDN should be final. |
470
|
| Line is longer than 80 characters. |
481
|
| Line is longer than 80 characters. |
483
|
| Line is longer than 80 characters. |
484
|
| Line has trailing spaces. |
491
|
| Line is longer than 80 characters. |
492
|
| Method 'addUserGroupEntry' is not designed for extension - needs to be abstract, final or empty. |
496
|
| Parameter userDN should be final. |
496
|
| Parameter groupName should be final. |
496
|
| Parameter groupDN should be final. |
496
|
| Line is longer than 80 characters. |
503
|
| Line is longer than 80 characters. |
505
|
| Line is longer than 80 characters. |
506
|
| Line has trailing spaces. |
513
|
| Line is longer than 80 characters. |
514
|
| Method 'removeUserGroupEntry' is not designed for extension - needs to be abstract, final or empty. |
518
|
| Parameter userDN should be final. |
518
|
| Parameter groupName should be final. |
518
|
| Parameter groupDN should be final. |
518
|
| Line is longer than 80 characters. |
525
|
| Line is longer than 80 characters. |
527
|
| Line is longer than 80 characters. |
528
|
| Line has trailing spaces. |
533
|
| Line has trailing spaces. |
535
|
| Missing a Javadoc comment. |
536
|
| Parameter domain should be final. |
536
|
| Parameter groupname should be final. |
536
|
| Line is longer than 80 characters. |
540
|
| Line is longer than 80 characters. |
550
|
| Line is longer than 80 characters. |
553
|
| Line is longer than 80 characters. |
554
|
| Line has trailing spaces. |
559
|
| Missing a Javadoc comment. |
560
|
| Parameter domain should be final. |
560
|
| Parameter username should be final. |
560
|
| Parameter gid should be final. |
560
|
| Line has trailing spaces. |
567
|
| '+' is not preceded with whitespace. |
568
|
| '+' is not followed by whitespace. |
568
|
| '+' is not preceded with whitespace. |
568
|
| '+' is not followed by whitespace. |
568
|
| Line is longer than 80 characters. |
569
|
| Line is longer than 80 characters. |
571
|
| Line is longer than 80 characters. |
572
|
| Line has trailing spaces. |
577
|
| Line is longer than 80 characters. |
579
|
| Line has trailing spaces. |
581
|
| Line is longer than 80 characters. |
582
|
| Method 'changeGroupID' is not designed for extension - needs to be abstract, final or empty. |
585
|
| Parameter username should be final. |
585
|
| Parameter groupname should be final. |
585
|
| Line is longer than 80 characters. |
588
|
| Line has trailing spaces. |
592
|
| Line is longer than 80 characters. |
593
|
| Line is longer than 80 characters. |
595
|
| Line is longer than 80 characters. |
599
|
| Line is longer than 80 characters. |
602
|
| Method 'changeGroupID' is not designed for extension - needs to be abstract, final or empty. |
602
|
| Parameter domain should be final. |
602
|
| Parameter username should be final. |
602
|
| Parameter groupname should be final. |
602
|
| Line is longer than 80 characters. |
605
|
| Line has trailing spaces. |
609
|
| Line is longer than 80 characters. |
611
|
| Line has trailing spaces. |
613
|
| Line is longer than 80 characters. |
614
|
| Method 'addToSecondaryGroup' is not designed for extension - needs to be abstract, final or empty. |
617
|
| Parameter username should be final. |
617
|
| Parameter groupname should be final. |
617
|
| Line has trailing spaces. |
620
|
| Line is longer than 80 characters. |
621
|
| Line is longer than 80 characters. |
623
|
| Line has trailing spaces. |
625
|
| Line is longer than 80 characters. |
627
|
| Line is longer than 80 characters. |
630
|
| Method 'addToSecondaryGroup' is not designed for extension - needs to be abstract, final or empty. |
630
|
| Parameter domain should be final. |
630
|
| Parameter username should be final. |
630
|
| Parameter groupname should be final. |
630
|
| Line is longer than 80 characters. |
636
|
| 'if' construct must use '{}'s. |
637
|
| Line has trailing spaces. |
641
|
| '+' is not preceded with whitespace. |
642
|
| '+' is not followed by whitespace. |
642
|
| '+' is not preceded with whitespace. |
642
|
| '+' is not followed by whitespace. |
642
|
| Line is longer than 80 characters. |
643
|
| Line is longer than 80 characters. |
645
|
| Line is longer than 80 characters. |
646
|
| Line has trailing spaces. |
651
|
| Line is longer than 80 characters. |
652
|
| Missing a Javadoc comment. |
652
|
| Parameter context should be final. |
652
|
| Parameter domain should be final. |
652
|
| Redundant throws: 'Exception' is unchecked exception. |
652
|
| 'if' construct must use '{}'s. |
653
|
gov/bnl/gums/ldap/LDAPUserGroupDB.java
Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.util.Date. |
18
|
| Using the '.*' form of import should be avoided - javax.naming.*. |
22
|
| Using the '.*' form of import should be avoided - javax.naming.directory.*. |
23
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
38
|
| Line has trailing spaces. |
39
|
| First sentence should end with a period. |
40
|
| Parameter factory should be final. |
41
|
| 'factory' hides a field. |
41
|
| Expected @param tag for 'factory'. |
41
|
| Parameter group should be final. |
41
|
| 'group' hides a field. |
41
|
| Expected @param tag for 'group'. |
41
|
| Line is longer than 80 characters. |
46
|
| Line has trailing spaces. |
48
|
| Method 'doesGroupExist' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Missing a Javadoc comment. |
49
|
| Line is longer than 80 characters. |
54
|
| Line is longer than 80 characters. |
55
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
59
|
| Line has trailing spaces. |
64
|
| Method 'createGroupIfNotExists' is not designed for extension - needs to be abstract, final or empty. |
65
|
| Missing a Javadoc comment. |
65
|
| 'if' construct must use '{}'s. |
66
|
| Method 'isMemberInGroup' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Missing a Javadoc comment. |
70
|
| Parameter user should be final. |
70
|
| Line is longer than 80 characters. |
75
|
| Line is longer than 80 characters. |
76
|
| Line is longer than 80 characters. |
79
|
| Line is longer than 80 characters. |
80
|
| Line has trailing spaces. |
85
|
| Missing a Javadoc comment. |
86
|
| Parameter user should be final. |
86
|
| 'if' construct must use '{}'s. |
87
|
| 'else' construct must use '{}'s. |
89
|
| '+' is not preceded with whitespace. |
90
|
| '+' is not followed by whitespace. |
90
|
| '+' is not preceded with whitespace. |
90
|
| '+' is not followed by whitespace. |
90
|
| '+' is not preceded with whitespace. |
90
|
| '+' is not followed by whitespace. |
90
|
| Method 'removeMember' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Parameter user should be final. |
93
|
| Line is longer than 80 characters. |
99
|
| Method 'addMember' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Missing a Javadoc comment. |
106
|
| Parameter user should be final. |
106
|
| Method 'loadUpdatedList' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Missing a Javadoc comment. |
110
|
| Parameter members should be final. |
110
|
| Line is longer than 80 characters. |
125
|
| Line is longer than 80 characters. |
139
|
| Line has trailing spaces. |
153
|
| Line is longer than 80 characters. |
155
|
| Line is longer than 80 characters. |
156
|
| Line has trailing spaces. |
158
|
| Line is longer than 80 characters. |
160
|
| Method 'retrieveRemovedMembers' is not designed for extension - needs to be abstract, final or empty. |
164
|
| Missing a Javadoc comment. |
164
|
| Method 'retrieveMembers' is not designed for extension - needs to be abstract, final or empty. |
168
|
| Missing a Javadoc comment. |
168
|
| 'if' construct must use '{}'s. |
175
|
| 'if' construct must use '{}'s. |
183
|
| Line is longer than 80 characters. |
188
|
| Line is longer than 80 characters. |
192
|
| Line is longer than 80 characters. |
193
|
| Method 'retrieveNewMembers' is not designed for extension - needs to be abstract, final or empty. |
199
|
| Missing a Javadoc comment. |
199
|
| Line has trailing spaces. |
202
|
gov/bnl/gums/ldap/package.html
Error | Line |
| Missing package documentation file. | 0 |