PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
2367

Files

FilesViolations
gov/bnl/gums/FileConfigurationStore.java 2
gov/bnl/gums/GUMS.java 1
gov/bnl/gums/GecosLdapAccountMapper.java 1
gov/bnl/gums/GecosMap.java 4
gov/bnl/gums/GecosNisAccountMapper.java 1
gov/bnl/gums/GridUser.java 2
gov/bnl/gums/MySQLPersistenceFactory.java 19
gov/bnl/gums/NisClient.java 5
gov/bnl/gums/ResourceManager.java 2
gov/bnl/gums/VOMSGroup.java 1
gov/bnl/gums/admin/CertCache.java 1
gov/bnl/gums/admin/CertToolkit.java 1
gov/bnl/gums/admin/GUMSAPIImpl.java 3
gov/bnl/gums/command/AbstractCommand.java 3
gov/bnl/gums/command/CommandLineToolkit.java 1
gov/bnl/gums/command/GUMSCommandLine.java 1
gov/bnl/gums/hibernate/HibernateMapping.java 4
gov/bnl/gums/hibernate/HibernateUserGroupDB.java 5
gov/bnl/gums/hibernate/Mapping.java 2
gov/bnl/gums/hibernate/User.java 2
gov/bnl/gums/ldap/LDAPMapDB.java 2
gov/bnl/gums/ldap/LDAPPersistenceFactory.java 2
gov/bnl/gums/ldap/LDAPUserGroupDB.java 2

gov/bnl/gums/FileConfigurationStore.java

ViolationLine
Avoid if (x != y) ..; else ..; 64
Avoid if (x != y) ..; else ..; 87

gov/bnl/gums/GUMS.java

ViolationLine
Avoid if (x != y) ..; else ..; 63

gov/bnl/gums/GecosLdapAccountMapper.java

ViolationLine
Avoid if (x != y) ..; else ..; 68

gov/bnl/gums/GecosMap.java

ViolationLine
Deeply nested if..then statements are hard to read 60
Avoid reassigning parameters such as 'gecos' 124
Avoid reassigning parameters such as 'gecos' 135
Avoid unused private methods such as 'printMap' 186

gov/bnl/gums/GecosNisAccountMapper.java

ViolationLine
Avoid if (x != y) ..; else ..; 70

gov/bnl/gums/GridUser.java

ViolationLine
Avoid calls to overridable methods during construction 34
Avoid calls to overridable methods during construction 36

gov/bnl/gums/MySQLPersistenceFactory.java

ViolationLine
Avoid duplicate imports such as 'java.util.Date' 10
Ensures that Connection objects are always closed after use 32
Ensures that Connection objects are always closed after use 133
Ensures that Connection objects are always closed after use 155
Ensures that Connection objects are always closed after use 174
Ensures that Connection objects are always closed after use 197
Ensures that Connection objects are always closed after use 262
Ensures that Connection objects are always closed after use 302
Ensures that Connection objects are always closed after use 336
Ensures that Connection objects are always closed after use 354
Ensures that Connection objects are always closed after use 406
Ensures that Connection objects are always closed after use 444
Ensures that Connection objects are always closed after use 461
Ensures that Connection objects are always closed after use 485
Ensures that Connection objects are always closed after use 509
Ensures that Connection objects are always closed after use 530
Ensures that Connection objects are always closed after use 565
Ensures that Connection objects are always closed after use 591
Ensures that Connection objects are always closed after use 618

gov/bnl/gums/NisClient.java

ViolationLine
Deeply nested if..then statements are hard to read 79
Avoid if (x != y) ..; else ..; 190
Avoid reassigning parameters such as 'gecos' 231
Avoid reassigning parameters such as 'gecos' 242
Avoid unused private methods such as 'printMap' 280

gov/bnl/gums/ResourceManager.java

ViolationLine
Avoid if (x != y) ..; else ..; 120
Avoid if (x != y) ..; else ..; 222

gov/bnl/gums/VOMSGroup.java

ViolationLine
Avoid if (x != y) ..; else ..; 285

gov/bnl/gums/admin/CertCache.java

ViolationLine
Avoid unnecessary constructors - the compiler will generate these for you 23

gov/bnl/gums/admin/CertToolkit.java

ViolationLine
Avoid reassigning parameters such as 'commaDN' 47

gov/bnl/gums/admin/GUMSAPIImpl.java

ViolationLine
Avoid unused private fields such as 'log' 18
Non-static initializers are confusing 245
Avoid if (x != y) ..; else ..; 257

gov/bnl/gums/command/AbstractCommand.java

ViolationLine
Avoid if (x != y) ..; else ..; 70
Avoid if (x != y) ..; else ..; 160
Avoid if (x != y) ..; else ..; 197

gov/bnl/gums/command/CommandLineToolkit.java

ViolationLine
Avoid reassigning parameters such as 'className' 27

gov/bnl/gums/command/GUMSCommandLine.java

ViolationLine
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. 133

gov/bnl/gums/hibernate/HibernateMapping.java

ViolationLine
Avoid unused imports such as 'OperationNotSupportedException' 16
Avoid unused formal parameters such as 'tx' 74
Avoid unused formal parameters such as 'tx' 116
Avoid unused formal parameters such as 'tx' 158

gov/bnl/gums/hibernate/HibernateUserGroupDB.java

ViolationLine
Avoid unused formal parameters such as 'tx' 79
Ensures that Connection objects are always closed after use 103
Avoid unused formal parameters such as 'tx' 217
Avoid unused formal parameters such as 'tx' 231
Avoid unused formal parameters such as 'tx' 241

gov/bnl/gums/hibernate/Mapping.java

ViolationLine
Avoid unused imports such as 'Date' 13
Avoid unnecessary constructors - the compiler will generate these for you 24

gov/bnl/gums/hibernate/User.java

ViolationLine
Avoid unused imports such as 'Date' 13
Avoid unnecessary constructors - the compiler will generate these for you 22

gov/bnl/gums/ldap/LDAPMapDB.java

ViolationLine
Avoid calls to overridable methods during construction 49
Avoid if (x != y) ..; else ..; 213

gov/bnl/gums/ldap/LDAPPersistenceFactory.java

ViolationLine
Avoid unused imports such as 'Name' 19
Avoid unused imports such as 'InitialDirContext' 28

gov/bnl/gums/ldap/LDAPUserGroupDB.java

ViolationLine
Avoid unused imports such as 'Date' 18
Avoid calls to overridable methods during construction 45