PMD Results

The following document contains the results of PMD 4.2.2.

Files

gums-client - gov/bnl/gums/admin/AdminSoapBindingStub.java

Violation Line
Avoid unused local variables such as 'enumsf'. 438
Avoid unused local variables such as 'enumdf'. 439
Avoid unused local variables such as 'arraysf'. 440
Avoid unused local variables such as 'arraydf'. 441
Avoid unused local variables such as 'simplesf'. 442
Avoid unused local variables such as 'simpledf'. 443
Avoid unused local variables such as 'simplelistsf'. 444
Avoid unused local variables such as 'simplelistdf'. 445

gums-client - gov/bnl/gums/admin/ClientVersion.java

Violation Line
Avoid unused imports such as 'java.net.URL' 13

gums-client - gov/bnl/gums/admin/GenerateFqanMapfile.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.configuration.Configuration' 8

gums-client - gov/bnl/gums/admin/ManualMapping_Remove.java

Violation Line
Avoid unused imports such as 'org.apache.axis.AxisFault' 9

gums-client - gov/bnl/gums/admin/Pool_AddRange.java

Violation Line
Avoid unused local variables such as 'accountBase'. 57

gums-client - gov/bnl/gums/admin/RemoteCommand.java

Violation Line
An empty statement (semicolon) not part of a loop 34

gums-core - gov/bnl/gums/CoreLogic.java

Violation Line
Avoid unused private fields such as 'log'. 27
Avoid unused local variables such as 'unknownCount'. 81
Avoid unused local variables such as 'usersInMap'. 232
Avoid unused method parameters such as 'createNewMappings'. 278 - 368

gums-core - gov/bnl/gums/FQAN.java

Violation Line
Avoid unused imports such as 'org.apache.log4j.Logger' 13

gums-core - gov/bnl/gums/GUMS.java

Violation Line
Avoid empty catch blocks 69
Avoid empty catch blocks 72
Avoid empty catch blocks 75

gums-core - gov/bnl/gums/GridUser.java

Violation Line
Avoid unused private methods such as 'removeSpaces(String)'. 207

gums-core - gov/bnl/gums/account/GecosMap.java

Violation Line
No need to import a type that lives in the same package 10
Avoid unused private methods such as 'printMap(PrintStream,Map,int)'. 188

gums-core - gov/bnl/gums/account/LdapAccountMapper.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.userGroup.LDAPUserGroup' 11
Ensure you override both equals() and hashCode() 69

gums-core - gov/bnl/gums/account/NISClient.java

Violation Line
Avoid unused private methods such as 'printMap(PrintStream,Map,int)'. 270

gums-core - gov/bnl/gums/admin/GUMSAPIImpl.java

Violation Line
Avoid unused imports such as 'java.io.BufferedReader' 20
Avoid unused imports such as 'java.io.ByteArrayInputStream' 21
Avoid unused imports such as 'java.io.FileReader' 23
Avoid unused imports such as 'java.io.InputStreamReader' 26
Avoid unused imports such as 'java.io.StringBufferInputStream' 27
Avoid unused imports such as 'gov.bnl.gums.db.ManualUserGroupDB' 38
Avoid unused local variables such as 'accountBase'. 69
Avoid unused local variables such as 'accountBase'. 500
Avoid unused local variables such as 'accountBase'. 565
These nested if statements could be combined 627 - 628
These nested if statements could be combined 657 - 658
These nested if statements could be combined 687 - 688
These nested if statements could be combined 719 - 720
These nested if statements could be combined 751 - 752
Avoid unused private methods such as 'getAccountPoolMapper(String)'. 789
Avoid unused private methods such as 'getVersionNoPatch()'. 891

gums-core - gov/bnl/gums/command/AbstractCommand.java

Violation Line
Avoid unused imports such as 'org.apache.log4j.Level' 19
Avoid unused imports such as 'org.glite.security.voms.VOMSValidator' 22
Avoid unused imports such as 'org.glite.security.voms.BasicVOMSTrustStore' 23
Avoid unused imports such as 'org.glite.security.util.DirectoryList' 24

gums-core - gov/bnl/gums/configuration/Configuration.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.userGroup.ManualUserGroup' 12
Avoid unused imports such as 'gov.bnl.gums.GridUser' 16
Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 24
Avoid unused imports such as 'org.xml.sax.SAXException' 27
Avoid empty catch blocks 567
Avoid empty catch blocks 579
Avoid empty catch blocks 589
Avoid empty catch blocks 600

gums-core - gov/bnl/gums/configuration/ConfigurationStore.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.GUMS' 9
Avoid unused imports such as 'gov.bnl.gums.GridUser' 10
Avoid unused imports such as 'gov.bnl.gums.persistence.PersistenceFactory' 11
Avoid unused imports such as 'gov.bnl.gums.userGroup.ManualUserGroup' 12
Avoid unused imports such as 'gov.bnl.gums.userGroup.UserGroup' 13
Avoid unused imports such as 'java.io.IOException' 15
Avoid unused imports such as 'java.util.Iterator' 20
Avoid unused imports such as 'java.util.Map' 21
Avoid unused imports such as 'org.apache.log4j.Logger' 23

gums-core - gov/bnl/gums/configuration/ConfigurationToolkit.java

Violation Line
Avoid unused imports such as 'java.io.FileInputStream' 35
Avoid unused imports such as 'java.io.InputStream' 37
Avoid unused imports such as 'java.io.StringBufferInputStream' 38

gums-core - gov/bnl/gums/configuration/DBConfigurationStore.java

Violation Line
Avoid unused imports such as 'java.io.BufferedWriter' 3
Avoid unused imports such as 'java.io.IOException' 5
Avoid unused imports such as 'java.io.StringWriter' 6
Avoid unused imports such as 'java.net.URL' 7
Avoid unused imports such as 'java.text.DateFormat' 8
Avoid unused imports such as 'java.text.ParseException' 9
Avoid unused imports such as 'java.text.SimpleDateFormat' 10
Avoid unused imports such as 'java.util.Iterator' 13
Avoid unused imports such as 'javax.xml.parsers.ParserConfigurationException' 15
Avoid unused imports such as 'org.xml.sax.SAXException' 18
Avoid unused imports such as 'gov.bnl.gums.GUMS' 20
No need to import a type that lives in the same package 21
Avoid unused imports such as 'gov.bnl.gums.persistence.HibernatePersistenceFactory' 23
Avoid unused imports such as 'gov.bnl.gums.persistence.LocalPersistenceFactory' 24
Avoid unused imports such as 'gov.bnl.gums.persistence.PersistenceFactory' 25

gums-core - gov/bnl/gums/configuration/FileConfigurationStore.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.GUMS' 9
Avoid unused imports such as 'gov.bnl.gums.persistence.HibernatePersistenceFactory' 10
Avoid unused imports such as 'gov.bnl.gums.persistence.LocalPersistenceFactory' 11
Avoid unused imports such as 'gov.bnl.gums.persistence.PersistenceFactory' 12
Avoid unused imports such as 'java.lang.ref.SoftReference' 21
Avoid unused imports such as 'java.util.Iterator' 27

gums-core - gov/bnl/gums/db/HibernateAccountMapperDB.java

Violation Line
Avoid unused imports such as 'java.util.ArrayList' 17
Avoid unused imports such as 'org.hibernate.type.StringType' 28
Avoid unused imports such as 'org.hibernate.type.Type' 29
Avoid unused method parameters such as 'tx'. 505 - 511
Avoid unused method parameters such as 'tx'. 513 - 519
Avoid unused method parameters such as 'tx'. 521 - 527
Avoid unused method parameters such as 'tx'. 529 - 535
Avoid unused method parameters such as 'tx'. 537 - 551
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 554

gums-core - gov/bnl/gums/db/HibernateConfigurationDB.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 263

gums-core - gov/bnl/gums/db/HibernateUserGroupDB.java

Violation Line
Avoid unused imports such as 'org.hibernate.type.StringType' 24
Avoid unused imports such as 'org.hibernate.type.Type' 25
Avoid unused method parameters such as 'tx'. 278 - 287
Avoid unused method parameters such as 'tx'. 289 - 301
Avoid unused method parameters such as 'tx'. 303 - 314
Avoid unused method parameters such as 'tx'. 316 - 328

gums-core - gov/bnl/gums/db/LDAPAccountMapperDB.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.GUMS' 13
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 341
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 449

gums-core - gov/bnl/gums/db/LDAPConfigurationDB.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.persistence.HibernatePersistenceFactory' 9
Avoid unused private fields such as 'factory'. 14

gums-core - gov/bnl/gums/db/ManualAccountMapperDB.java

Violation Line
Avoid unused imports such as 'java.util.List' 9

gums-core - gov/bnl/gums/persistence/LDAPPersistenceFactory.java

Violation Line
Avoid unused imports such as 'java.io.FileInputStream' 21
Avoid unused imports such as 'java.io.FileOutputStream' 22
Avoid unused imports such as 'java.io.InputStream' 23
Avoid unused imports such as 'java.security.KeyStore' 24
Avoid unused imports such as 'java.security.cert.CertificateFactory' 25
Avoid unused imports such as 'java.security.cert.X509Certificate' 26
Avoid unused private fields such as 'trustStore'. 55

gums-core - gov/bnl/gums/persistence/LocalPersistenceFactory.java

Violation Line
Avoid unused imports such as 'gov.bnl.gums.db.LDAPAccountMapperDB' 12
Avoid unused imports such as 'java.lang.ref.SoftReference' 18
Avoid unused imports such as 'org.hibernate.SessionFactory' 28

gums-core - gov/bnl/gums/userGroup/VOMSUserGroup.java

Violation Line
Avoid unused imports such as 'org.apache.log4j.Level' 18
These nested if statements could be combined 210 - 211
These nested if statements could be combined 230 - 231

gums-core - gov/bnl/gums/userGroup/VomsServer.java

Violation Line
Avoid unused private fields such as 'log'. 18
Avoid unused private fields such as 'db'. 26

gums-core - org/glite/security/voms/VOMSAdminSoapBindingStub.java

Violation Line
Avoid unused local variables such as 'enumsf'. 710
Avoid unused local variables such as 'enumdf'. 711
Avoid unused local variables such as 'arraysf'. 712
Avoid unused local variables such as 'arraydf'. 713
Avoid unused local variables such as 'simplesf'. 714
Avoid unused local variables such as 'simpledf'. 715
Avoid unused local variables such as 'simplelistsf'. 716
Avoid unused local variables such as 'simplelistdf'. 717

gums-core - org/glite/security/voms/VOMSException.java

Violation Line
Avoid unused local variables such as 'other'. 17

gums-service - gov/bnl/gums/service/ConfigurationWebToolkit.java

Violation Line
These nested if statements could be combined 451 - 455
These nested if statements could be combined 469 - 473

gums-service - gov/bnl/gums/service/GUMSXACMLMappingServiceImpl.java

Violation Line
Error while parsing /home/jpackard/workspace/privilege-temp/gums-service/src/main/java/gov/bnl/gums/service/GUMSXACMLMappingServiceImpl.java: Can't use generics unless running in JDK 1.5 mode! 0
Error while parsing /home/jpackard/workspace/privilege-temp/gums-service/src/main/java/gov/bnl/gums/service/GUMSXACMLMappingServiceImpl.java: Can't use generics unless running in JDK 1.5 mode! 0
Error while parsing /home/jpackard/workspace/privilege-temp/gums-service/src/main/java/gov/bnl/gums/service/GUMSXACMLMappingServiceImpl.java: Can't use generics unless running in JDK 1.5 mode! 0