PMD Results

The following document contains the results of PMD 3.9.

Files

gums-client - gov/bnl/gums/admin/AdminCommandLine.java

ViolationLine
Avoid unused imports such as 'gov.bnl.gums.configuration.Configuration'9
Avoid unused private fields such as 'log'.18

gums-client - gov/bnl/gums/admin/AdminSoapBindingStub.java

ViolationLine
Avoid unused constructor parameters such as 'enumdf'.317 - 356
Avoid unused constructor parameters such as 'simplesf'.317 - 356
Avoid unused constructor parameters such as 'enumsf'.317 - 356
Avoid unused constructor parameters such as 'simplelistdf'.317 - 356
Avoid unused constructor parameters such as 'simplelistsf'.317 - 356
Avoid unused constructor parameters such as 'simpledf'.317 - 356
Avoid unused local variables such as 'enumsf'.327
Avoid unused local variables such as 'enumdf'.328
Avoid unused local variables such as 'simplesf'.331
Avoid unused local variables such as 'simpledf'.332
Avoid unused local variables such as 'simplelistsf'.333
Avoid unused local variables such as 'simplelistdf'.334

gums-client - gov/bnl/gums/admin/ClientVersion.java

ViolationLine
Avoid unused imports such as 'java.io.File'13
Avoid unused imports such as 'org.apache.commons.cli.Option'16
Avoid unused imports such as 'gov.bnl.gums.GUMS'20

gums-client - gov/bnl/gums/admin/GenerateFqanMapFile.java

ViolationLine
Avoid unused imports such as 'gov.bnl.gums.configuration.Configuration'8

gums-client - gov/bnl/gums/admin/GenerateMap.java

ViolationLine
Avoid unused imports such as 'java.net.URL'13

gums-client - gov/bnl/gums/admin/HostCommandLine.java

ViolationLine
Avoid unused private fields such as 'log'.16

gums-client - gov/bnl/gums/admin/ManualGroup_Add.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'9
Avoid unused imports such as 'java.net.ConnectException'13
Avoid unused imports such as 'java.net.InetAddress'14
Avoid unused imports such as 'java.net.URL'15
Avoid unused imports such as 'gov.bnl.gums.command.AbstractCommand'16

gums-client - gov/bnl/gums/admin/ManualGroup_Remove.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'9
Avoid unused imports such as 'java.net.ConnectException'13
Avoid unused imports such as 'java.net.InetAddress'14
Avoid unused imports such as 'java.net.URL'15
Avoid unused imports such as 'gov.bnl.gums.command.AbstractCommand'16

gums-client - gov/bnl/gums/admin/ManualMapping_Add.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'9
Avoid unused imports such as 'java.net.ConnectException'13
Avoid unused imports such as 'java.net.InetAddress'14
Avoid unused imports such as 'java.net.URL'15
Avoid unused imports such as 'gov.bnl.gums.command.AbstractCommand'16

gums-client - gov/bnl/gums/admin/ManualMapping_Remove.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'9
Avoid unused imports such as 'java.net.ConnectException'13
Avoid unused imports such as 'java.net.InetAddress'14
Avoid unused imports such as 'java.net.URL'15
Avoid unused imports such as 'gov.bnl.gums.command.AbstractCommand'16

gums-client - gov/bnl/gums/admin/Pool_AddRange.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'9
Avoid unused imports such as 'java.net.ConnectException'13
Avoid unused imports such as 'java.net.InetAddress'14
Avoid unused imports such as 'java.net.URL'15
Avoid unused imports such as 'gov.bnl.gums.command.AbstractCommand'16
Avoid unused local variables such as 'accountBase'.66

gums-client - gov/bnl/gums/admin/RemoteCommand.java

ViolationLine
Avoid unused imports such as 'org.apache.axis.AxisFault'12
Avoid unused imports such as 'java.net.ConnectException'19
Avoid unused imports such as 'java.util.logging.Logger'22
An empty statement (semicolon) not part of a loop41

gums-client - gov/bnl/gums/admin/ServerVersion.java

ViolationLine
Avoid unused imports such as 'java.io.File'13

gums-core - gov/bnl/gums/GridUser.java

ViolationLine
Avoid unused private methods such as 'removeSpaces(String)'.155

gums-core - gov/bnl/gums/ResourceManager.java

ViolationLine
Avoid unused local variables such as 'unknownCount'.81
Avoid unused local variables such as 'usersInMap'.233

gums-core - gov/bnl/gums/account/AccountPoolMapper.java

ViolationLine
Avoid unused private fields such as 'assignmentString'.41

gums-core - gov/bnl/gums/account/GecosMap.java

ViolationLine
No need to import a type that lives in the same package10
Avoid unused private methods such as 'printMap(PrintStream,Map,int)'.189

gums-core - gov/bnl/gums/account/LdapAccountMapper.java

ViolationLine
Avoid unused imports such as 'gov.bnl.gums.GUMS'9

gums-core - gov/bnl/gums/account/NISClient.java

ViolationLine
Avoid unused private methods such as 'printMap(PrintStream,Map,int)'.271

gums-core - gov/bnl/gums/admin/GUMSAPIImpl.java

ViolationLine
Avoid unused local variables such as 'accountBase'.60
Avoid unused local variables such as 'accountBase'.373
Avoid unused local variables such as 'accountBase'.421
These nested if statements could be combined487 - 488
These nested if statements could be combined521 - 522
These nested if statements could be combined556 - 557
These nested if statements could be combined591 - 592
These nested if statements could be combined626 - 627
Avoid unused private methods such as 'getAccountPoolMapper(String)'.667

gums-core - gov/bnl/gums/command/AbstractCommand.java

ViolationLine
Avoid unused imports such as 'java.net.URL'13

gums-core - gov/bnl/gums/configuration/Configuration.java

ViolationLine
Avoid unused imports such as 'gov.bnl.gums.userGroup.ManualUserGroup'12

gums-core - gov/bnl/gums/configuration/ConfigurationStore.java

ViolationLine
Avoid unused imports such as 'java.io.IOException'9

gums-core - gov/bnl/gums/configuration/ConfigurationToolkit.java

ViolationLine
Avoid duplicate imports such as 'gov.bnl.gums.account.GecosNisAccountMapper'16
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead.160

gums-core - gov/bnl/gums/db/HibernateAccountMapperDB.java

ViolationLine
Avoid unused method parameters such as 'tx'.517 - 524
Avoid unused method parameters such as 'tx'.526 - 530
Avoid unused method parameters such as 'tx'.532 - 536
Avoid unused method parameters such as 'tx'.538 - 544
Avoid unused method parameters such as 'tx'.546 - 560
Avoid unused method parameters such as 'tx'.562 - 568

gums-core - gov/bnl/gums/db/HibernateUserGroupDB.java

ViolationLine
Avoid unused imports such as 'net.sf.hibernate.util.ReflectHelper'26
Avoid unused method parameters such as 'tx'.279 - 287
Avoid unused method parameters such as 'tx'.289 - 301
Avoid unused method parameters such as 'tx'.303 - 311
Avoid unused method parameters such as 'tx'.313 - 325

gums-core - gov/bnl/gums/db/ManualAccountMapperDB.java

ViolationLine
Avoid unused imports such as 'java.util.List'9

gums-core - gov/bnl/gums/persistence/LDAPPersistenceFactory.java

ViolationLine
Avoid unused private methods such as 'addCertToTrustStore()'.599

gums-core - gov/bnl/gums/persistence/LocalPersistenceFactory.java

ViolationLine
Overriding method merely calls super251 - 253
Overriding method merely calls super267 - 269

gums-core - gov/bnl/gums/persistence/PersistenceFactory.java

ViolationLine
Avoid unused imports such as 'java.util.Iterator'15

gums-core - gov/bnl/gums/userGroup/LDAPUserGroup.java

ViolationLine
Avoid unused private fields such as 'conf'.51

gums-core - gov/bnl/gums/userGroup/VOMSUserGroup.java

ViolationLine
Avoid unused imports such as 'gov.bnl.gums.db.HibernateUserGroupDB'13
Avoid unused imports such as 'gov.bnl.gums.persistence.LDAPPersistenceFactory'15
Avoid unused private fields such as 'resourceAdminLog'.56
These nested if statements could be combined199 - 200
These nested if statements could be combined219 - 220

gums-core - gov/bnl/gums/userGroup/VomsServer.java

ViolationLine
Avoid unused private fields such as 'log'.17
Avoid unused private fields such as 'db'.25

gums-service - gov/bnl/gums/service/ConfigurationWebToolkit.java

ViolationLine
These nested if statements could be combined399 - 403
These nested if statements could be combined417 - 421

gums-service - gov/bnl/gums/service/GUMSAuthZService.java

ViolationLine
Avoid unused constructor parameters such as 'temp'.19 - 22
Avoid unused local variables such as 'temp'.21